Skip to content

Add routing and navigation for Saved Articles page behind feature switch#996

Open
vlbee wants to merge 8 commits into
mainfrom
vb-ld/add-saved-article-routing-behind-switch
Open

Add routing and navigation for Saved Articles page behind feature switch#996
vlbee wants to merge 8 commits into
mainfrom
vb-ld/add-saved-article-routing-behind-switch

Conversation

@vlbee

@vlbee vlbee commented Feb 17, 2023

Copy link
Copy Markdown
Member

What does this change?

  • Adds routing and navigation for new Saved Articles page behind a feature switch.
  • Adds initial Cypress tests for on/off switch pages and TDD.

Signed in users on the Apps have the ability to save articles and frequently request to view their saved articles when they sign in on web. We are adding a page to view those articiles here.

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

@vlbee
vlbee requested a review from lindseydew February 17, 2023 16:07
@vlbee
vlbee marked this pull request as ready for review February 17, 2023 16:30

@lindseydew lindseydew left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome sauce work 💃

Comment thread client/components/shared/nav/NavConfig.tsx
Comment thread shared/featureSwitches.ts
Comment thread cypress/integration/parallel-6/savedArticles.spec.ts
Comment thread cypress/integration/parallel-6/savedArticles.spec.ts Outdated
Comment thread cypress/integration/parallel-6/savedArticles.spec.ts
Comment thread cypress/integration/parallel-6/savedArticles.spec.ts Outdated
@vlbee
vlbee force-pushed the vb-ld/add-saved-article-routing-behind-switch branch from c152b96 to 2a75263 Compare February 21, 2023 17:53
Comment thread shared/featureSwitches.ts
Comment thread shared/featureSwitches.ts Outdated
Comment thread shared/featureSwitches.ts Outdated
@vlbee
vlbee force-pushed the vb-ld/add-saved-article-routing-behind-switch branch from 2a75263 to dda4adf Compare March 1, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants