-
Notifications
You must be signed in to change notification settings - Fork 4
Add routing and navigation for Saved Articles page behind feature switch #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vlbee
wants to merge
8
commits into
main
Choose a base branch
from
vb-ld/add-saved-article-routing-behind-switch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+113
−6
Open
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7d083e3
Add savedArticles feature switch in OFF state
vlbee 2317c76
Add SavedArticle Page routing behind switch
vlbee 992b2b7
Add SavedArticles Navigation behind switch
vlbee 03509b1
Add explicit override for testing the feature switch
lindseydew 0e1bcd5
Add switchUrl override to the navigation page
lindseydew b812cf6
Merge pull request #999 from guardian/ld-switches-configuration
vlbee dda4adf
Add mechanism to override Cypress feature switch state
vlbee f46e1b0
Merge remote-tracking branch 'origin/main' into vb-ld/add-saved-artic…
vlbee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| // TODO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { NAV_LINKS } from '../../shared/nav/NavConfig'; | ||
| import { PageContainer } from '../Page'; | ||
|
|
||
| export const SavedArticles = () => { | ||
| return ( | ||
| <PageContainer | ||
| selectedNavItem={NAV_LINKS.savedArticles} | ||
| pageTitle={NAV_LINKS.savedArticles.title} | ||
| > | ||
| <p>There is nothing to see here yet</p> | ||
| </PageContainer> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { featureSwitches } from '../../../shared/featureSwitches'; | ||
|
|
||
| if (!featureSwitches.savedArticles) { | ||
|
vlbee marked this conversation as resolved.
Outdated
|
||
| describe('Feature Switch OFF: Saved Articles', () => { | ||
| beforeEach(() => { | ||
| cy.session('auth', () => { | ||
| cy.setCookie('gu-cmp-disabled', 'true'); | ||
| }); | ||
| }); | ||
|
|
||
| it('redirects to account overview homepage from /saved-articles route ', () => { | ||
| cy.visit('/saved-articles'); | ||
|
|
||
| cy.url().should('not.contain', '/saved-articles'); | ||
|
|
||
| // check Navigation/Page Title | ||
| cy.findAllByText('Account overview').should( | ||
| 'have.length.at.least', | ||
| 1, | ||
| ); | ||
| cy.findAllByText('Saved articles').should('have.length', 0); | ||
|
vlbee marked this conversation as resolved.
|
||
| }); | ||
| }); | ||
| } | ||
|
|
||
| if (featureSwitches.savedArticles) { | ||
| describe('Feature Switch ON: Saved Article', () => { | ||
| beforeEach(() => { | ||
| cy.session('auth', () => { | ||
| cy.setCookie('gu-cmp-disabled', 'true'); | ||
| }); | ||
| }); | ||
|
|
||
| it('displays Saved Article page', () => { | ||
| cy.visit('/saved-articles'); | ||
|
|
||
| cy.findAllByText('Saved articles').should('have.length', 2); | ||
|
vlbee marked this conversation as resolved.
|
||
| }); | ||
| }); | ||
| } | ||
|
vlbee marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.