Fix/72 remove duration minutes#76
Merged
Merged
Conversation
Berny-ft
reviewed
May 27, 2026
Contributor
There was a problem hiding this comment.
Not 100% sure, but I don't think the migration file is needed since the schema is the same for everyone on Supabase after the migration.
RenaudBernier
requested changes
May 27, 2026
| @@ -0,0 +1 @@ | |||
| ALTER TABLE "coaching_sessions" DROP COLUMN "duration_minutes";--> statement-breakpoint | |||
Member
There was a problem hiding this comment.
The migration is not needed, we use schema.ts as our single source of truth and push changes with db:push
Contributor
Author
There was a problem hiding this comment.
Changes made and pushed
martin0024
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72
Overview
Removed
duration_minutescolumn from thecoaching_sessionstable to establish a single source of truth. Session duration now comes directly from the related service record instead of being duplicated in the coaching_sessions table.Changes made:
durationMinutesfield from thecoachingSessionsschema definitionsubmitAvailabilitiesaction to no longer handle duration (implicitly retrieved from service)Testing
submitAvailabilitiescreates coaching sessions without duration_minutes fieldScreenshots / Screencasts
N/A - Database schema change only
Checklist
Notes
This is a breaking change. Any code accessing
coachingSessions.durationMinuteswill need to fetch the duration from the relatedservicesrecord instead.