Skip to content

Fix/72 remove duration minutes #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin0024 merged 2 commits into from
May 29, 2026
Merged

Fix/72 remove duration minutes #76

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe8302d
refactor(coaching-sessions): remove duration_minutes column
maxiDeee May 26, 2026
d5a790f
refactor(schema): remove duration_minutes from coaching_sessions
maxiDeee May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/coaching/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ export async function submitAvailabilities({
userId: user.id,
serviceId: service.id,
coachId: service.coachId,
durationMinutes: service.durationMinutes,
selectedTimeSlots: availabilities,
status: "awaiting_payment",
})
Expand Down
1 change: 1 addition & 0 deletions drizzle/0001_remove_duration_minutes.sql
View file
Open in desktop

@Berny-ft Berny-ft May 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure, but I don't think the migration file is needed since the schema is the same for everyone on Supabase after the migration.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE "coaching_sessions" DROP COLUMN "duration_minutes";--> statement-breakpoint

@RenaudBernier RenaudBernier May 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration is not needed, we use schema.ts as our single source of truth and push changes with db:push

@maxiDeee maxiDeee May 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made and pushed

1 change: 0 additions & 1 deletion lib/db/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ export const coachingSessions = pgTable("coaching_sessions", {
.references(() => profiles.id, { onDelete: "cascade" })
.notNull(),
scheduledAt: timestamp("scheduled_at"),
durationMinutes: integer("duration_minutes").notNull().default(60),
status: sessionStatusEnum("status").notNull().default("pending"),
meetingUrl: text("meeting_url"),
notes: text("notes"),
Expand Down
Loading