fix: sign up user should always refresh contacts - #2614
Merged
Conversation
…rovided. Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
svienot
added
Bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2614 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 184 184
Lines 7446 7446
Branches 1489 1493 +4
=======================================
Hits 7443 7443
Misses 3 3 🚀 New features to boost your workflow:
|
svienot
changed the title
ericleponner
approved these changes
Apr 8, 2026
github-project-automation
Bot
moved this from 👷 In progress
to 👀 In review
in Transaction Tool
Kolpic
pushed a commit
that referenced
this pull request
Apr 15, 2026
* signUpUser() should always fetch contacts, even when no nickname is provided. Signed-off-by: Simon Viénot <simon.vienot@icloud.com> * Re-enable skipped test. Signed-off-by: Simon Viénot <simon.vienot@icloud.com> --------- Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
One-line change to make sure signUpUser() refreshes the contact list even when no nickname is registered for the created user.
This fix allows to re-enable the previously skipped automation test 'Verify admin user can remove user from the organization'.
Related issue(s):
Fixes #2563