Skip to content

fix: sign up user should always refresh contacts #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericleponner merged 2 commits into from
Apr 8, 2026
Merged

fix: sign up user should always refresh contacts #2614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3505a6d
signUpUser() should always fetch contacts, even when no nickname is p…
svienot Apr 8, 2026
86283db
Re-enable skipped test.
svienot Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion automation/tests/organizationContactListTests.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ test.describe('Organization Contact List tests @organization-basic', () => {
expect(isUserAdded).toBe(true);
});

test.skip('Verify admin user can remove user from the organization', async () => {
test('Verify admin user can remove user from the organization', async () => {
const newUserEmail = generateRandomEmail();
await organizationPage.signInOrganization(
adminUser.email,
Expand Down
2 changes: 1 addition & 1 deletion front-end/src/renderer/pages/ContactList/SignUpUser/SignUpUser.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ const handleLinkAccount = async () => {
organization_user_id_owner: user.selectedOrganization.userId,
nickname: nickname.value,
});
await contacts.fetch();
}
await contacts.fetch();
} catch (error) {
logger.error('Failed to sign up user', { error });
toastManager.error('Failed to sign up user');
Expand Down
Loading