Skip to content

Round error handling #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abdulrahman0044 wants to merge 2 commits into
base: master
Choose a base branch
from
+55 −8
Open

Round error handling #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b57ee7
improve the doc for solving common errors while running on local machine
Abdulrahman0044 Mar 31, 2026
49e2ada
handles errors related to Rounds not fetching
Abdulrahman0044 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions dev.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ Other frontend development commands:
* `npm run lint`: Lint the code
* `npm run format`: Format the code

**NB**: If you are getting `index.html` static file not found error, run `npm run build` to create the file. If the errors persist, copy `montage\montage\static\a\index.html` and manually copy and paste it to a new file in the `montage/static/index.html`.

### 5. Use the Makefile to start the backend
* Open a new terminal tab and change directory to root of repo
* Copy and edit `config.dev.yaml` based on `config.default.yaml`
Expand All @@ -88,6 +90,13 @@ This will build the docker image for the montage backend and start the container
* `make logs` : Stream the backend container logs in real-time.
* `make restart` : Restart the backend container

**NB**: if there is a conflict during the installation of the python libraries, do the following:

* Create a virtual environment by running `tox`
* On windows, activate the environment using: `.tox\py311\Scripts\activate`
* On Linux, use `source .tox/py311/bin/activate`
* Then run `make start`.

### 6. Access the Application
* With development server: Open http://localhost:5173 in your browser (frontend)
* With backend serving frontend: Open http://localhost:5001 in your browser
Expand Down
37 changes: 31 additions & 6 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 15 additions & 2 deletions montage/rdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@

from clastic.errors import Forbidden

import logging
logger = logging.getLogger(__name__)

from .utils import (format_date,
basestring,
to_unicode,
Expand Down Expand Up @@ -1554,7 +1557,12 @@ def activate_round(self, round_id):
return

def add_entries_from_cat(self, round_id, cat_name):
rnd = self.user_dao.get_round(round_id)
try:
rnd = self.user_dao.get_round(round_id)
except Exception as e:
logger.error("Round not found: %s", round_id)
raise InvalidAction("Round not found")

if ENV_NAME == 'dev':
source = 'remote'
else:
Expand All @@ -1569,7 +1577,12 @@ def add_entries_from_cat(self, round_id, cat_name):
return entries

def add_entries_by_name(self, round_id, file_names):
rnd = self.user_dao.get_round(round_id)
try:
rnd = self.user_dao.get_round(round_id)
except Exception as e:
logger.error("Round not found: %s", round_id)
raise InvalidAction("Round not found")

if ENV_NAME == 'dev':
source = 'remote'
else:
Expand Down