fix(install): use sudo for .env writes in --upgrade#2736
Merged
Conversation
do_upgrade() mutates $INSTALL_DIR/.env (typically /opt/HelixML, root-owned from a sudo install) without sudo, so the backup cp, sed -i, and append fail with "Permission denied" whenever the operator runs install.sh as a non-root user. Docker itself works because the user is in the docker group, which masks that the file writes still need root. Compute a SUDO prefix only when .env is not writable (and not Git Bash), and apply it to cp/sed/rm. Switch the append from `>> file` to `tee -a` since the redirect runs in the unprivileged shell where sudo can't help. User-owned installs are unaffected (SUDO stays empty). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
./install.sh --upgradefails on a standard controlplane install:do_upgrade()writes to$INSTALL_DIR/.env(typically/opt/HelixML, root-owned from the original sudo install) withoutsudo: the backupcp, thesed -irewrite, and the append all run as the unprivileged operator. Docker commands succeed because the user is in thedockergroup, which masks that the file writes still need root.Fix
Compute a
SUDOprefix indo_upgrade()only when.envis not writable (and not Git Bash), and apply it to the file mutations:$SUDO cpfor the backup$SUDO sed -i/$SUDO rmfor the in-place rewriteprintf ... | $SUDO tee -afor the append (the old>> fileredirect runs in the unprivileged shell, sosudoonprintfwouldn't help)User-owned installs are unaffected:
SUDOstays empty.bash -npasses.Test
/opt/HelixML, operator in docker group: upgrade now backs up and rewrites.env, then pulls and recreates.SUDOempty, behaviour unchanged.🤖 Generated with Claude Code