Skip to content

fix(install): use sudo for .env writes in --upgrade #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chocobar merged 1 commit into from
Jun 25, 2026
+11 −4
Merged

fix(install): use sudo for .env writes in --upgrade #2736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,16 +937,23 @@ do_upgrade() {
esac
fi

# $INSTALL_DIR is typically root-owned (/opt/HelixML created by a sudo
# install), so .env writes need sudo even when docker runs without it.
local SUDO=""
if [ "$ENVIRONMENT" != "gitbash" ] && [ ! -w "$INSTALL_DIR/.env" ]; then
SUDO="sudo"
fi

local backup="$INSTALL_DIR/.env.bak.$(date +%Y%m%d-%H%M%S)"
cp "$INSTALL_DIR/.env" "$backup"
$SUDO cp "$INSTALL_DIR/.env" "$backup"
echo "Backed up .env to $backup"

# Rewrite HELIX_VERSION in place. If the line is absent, append it.
if grep -qE '^HELIX_VERSION=' "$INSTALL_DIR/.env"; then
sed -i.tmp "s|^HELIX_VERSION=.*|HELIX_VERSION=${target_version}|" "$INSTALL_DIR/.env"
rm -f "$INSTALL_DIR/.env.tmp"
$SUDO sed -i.tmp "s|^HELIX_VERSION=.*|HELIX_VERSION=${target_version}|" "$INSTALL_DIR/.env"
$SUDO rm -f "$INSTALL_DIR/.env.tmp"
else
printf '\nHELIX_VERSION=%s\n' "$target_version" >> "$INSTALL_DIR/.env"
printf '\nHELIX_VERSION=%s\n' "$target_version" | $SUDO tee -a "$INSTALL_DIR/.env" >/dev/null
fi
echo "Set HELIX_VERSION=$target_version in $INSTALL_DIR/.env"

Expand Down
Loading