feat: support for custom taxonomies for schema property to taxonomy - #1556
Open
michaelclaesson wants to merge 6 commits into
Open
feat: support for custom taxonomies for schema property to taxonomy #1556michaelclaesson wants to merge 6 commits into
michaelclaesson wants to merge 6 commits into
Conversation
michaelclaesson
force-pushed
the
feat/schema-taxonomy-filter
branch
from
October 13, 2025 16:11
1c59c84 to
a5eaf38
Compare
…ting custom taxonomies from schema prop
michaelclaesson
force-pushed
the
feat/schema-taxonomy-filter
branch
from
October 13, 2025 16:12
a5eaf38 to
9352a39
Compare
sebastianthulin
requested changes
Oct 16, 2025
| ][$schemaType] ?? []; | ||
| ]; | ||
|
|
||
| $taxonomies = \apply_filters('Municipio/Schema/Taxonomy/' . $schemaType, $map[$schemaType] ?? [], $schemaType, $this->taxonomyFactory, $this->schemaToPostTypeResolver); |
Contributor
Author
There was a problem hiding this comment.
I suppose the mock test signature for the wp service has to be changed since we've added applyFilters. I'm not familiar with your test setup though so out on deep water.
Member
There was a problem hiding this comment.
$this->wpService->applyFilters(
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add employment type to JobPosting taxonomies and add filter for injecting custom taxonomies from schema prop