Skip to content

feat: support for custom taxonomies for schema property to taxonomy #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelclaesson wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: support for custom taxonomies for schema property to taxonomy #1556

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85799bf
build: update package file versions to 2.168.29
Oct 13, 2025
9352a39
Add employment type to JobPosting taxonomies and add filter for injec…
michaelclaesson Oct 13, 2025
04a3e40
Use applyFilters from wp service
michaelclaesson Oct 16, 2025
f465d59
Merge branch 'main' into feat/schema-taxonomy-filter
sebastianthulin Oct 21, 2025
f8cd52a
Merge branch 'main' into feat/schema-taxonomy-filter
sebastianthulin Jan 20, 2026
68cd145
fix: resolve failing tests.
Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions library/SchemaData/Taxonomy/TaxonomiesFromSchemaType/TaxonomiesFromSchemaType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,19 @@ public function __construct(
* @return array An array of TaxonomyInterface objects.
*/
public function create(string $schemaType): array
{
return [
{
$map = [
'JobPosting' => $this->getJobPostingTaxonomies(),
'Event' => $this->getEventTaxonomies(),
'Project' => $this->getProjectTaxonomies(),
'ExhibitionEvent' => $this->getExhibitionEventTaxonomies(),
'ElementarySchool' => $this->getElementarySchoolTaxonomies(),
'Preschool' => $this->getPreschoolTaxonomies(),
][$schemaType] ?? [];
];

$taxonomies = \apply_filters('Municipio/Schema/Taxonomy/' . $schemaType, $map[$schemaType] ?? [], $schemaType, $this->taxonomyFactory, $this->schemaToPostTypeResolver);

@sebastianthulin sebastianthulin Oct 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use wpService.

@sebastianthulin sebastianthulin Oct 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will make tests pass.

@michaelclaesson michaelclaesson Oct 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the mock test signature for the wp service has to be changed since we've added applyFilters. I'm not familiar with your test setup though so out on deep water.

@sebastianthulin sebastianthulin Jan 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$this->wpService->applyFilters(


return $taxonomies;
}

/**
Expand Down Expand Up @@ -73,6 +77,7 @@ private function getJobPostingTaxonomies(): array
return [
$this->createTaxonomy('JobPosting', 'relevantOccupation', $this->wpService->__('Job Categories', 'municipio'), $this->wpService->__('Job Category', 'municipio')),
$this->createTaxonomy('JobPosting', 'validThrough', $this->wpService->__('Latest Application Dates', 'municipio'), $this->wpService->__('Latest Application Date', 'municipio')),
$this->createTaxonomy('JobPosting', 'employmentType', $this->wpService->__('Employment Types', 'municipio'), $this->wpService->__('Employment Type', 'municipio')),
];
}

Expand Down
Loading