Skip to content

fix(agentic): validate tools settings#2143

Merged
marrouchi merged 1 commit into
mainfrom
fix/agentic-tools-settings-validation
Jul 21, 2026
Merged

fix(agentic): validate tools settings#2143
marrouchi merged 1 commit into
mainfrom
fix/agentic-tools-settings-validation

Conversation

@yassinedorbozgithub

@yassinedorbozgithub yassinedorbozgithub commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Screenshots

  • After the fix
image
  • Before the fix
image

Summary

This PR adds validation for tool settings in the agentic package to ensure tool configurations are checked before use. It prevents invalid or incomplete settings from being accepted, improving reliability and reducing runtime failures.

Why

Invalid tool settings can lead to unexpected behavior or runtime errors that are difficult to diagnose. Validating configuration early provides clearer feedback and ensures only valid tool definitions are executed.

How to review

  • Review the tool settings validation logic in the agentic package.
  • Verify the validation rules and error handling for invalid configurations.
  • Confirm existing valid tool configurations continue to work without changes.

Validation

  • Tested with valid tool settings to confirm they are accepted.
  • Tested with invalid and incomplete tool settings to verify appropriate validation errors are returned.
  • Verified no regressions in the existing tool configuration workflow.

@yassinedorbozgithub yassinedorbozgithub self-assigned this Jul 20, 2026
@yassinedorbozgithub yassinedorbozgithub added the bug Something isn't working label Jul 20, 2026
@marrouchi
marrouchi merged commit c5405dc into main Jul 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants