Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions packages/agentic/src/__tests__/validation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,39 @@ describe('validateWorkflow', () => {
expect(result.success).toBe(true);
});

it('validates settings of non-task (bound) defs against their action schema', () => {
const buildWorkflow = (settings: Record<string, unknown>) => ({
defs: {
retrieve_rag_content: {
kind: 'tools',
action: 'retrieve_rag_content',
settings,
},
},
flow: [],
outputs: {},
});
const options = {
bindingKinds,
actions: {
retrieve_rag_content: {
settingSchema: z.strictObject({
include_inactive: z.boolean().optional(),
}),
},
},
};

expect(
validateWorkflow(buildWorkflow({ include_inactivdse: false }), options)
.success,
).toBe(false);
expect(
validateWorkflow(buildWorkflow({ include_inactive: false }), options)
.success,
).toBe(true);
});

it('reports missing actions with code, actionName and path', () => {
const workflow = {
defs: mergeTaskDefs({
Expand Down
12 changes: 12 additions & 0 deletions packages/agentic/src/bindings/base-binding.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export type BindingActionPolicy = 'forbidden' | 'optional' | 'required';

export type BindingValidationActionMetadata = {
supportedBindings?: readonly string[];
settingSchema?: z.ZodTypeAny;
};

export type BindingKindDescriptor<
Expand Down Expand Up @@ -341,6 +342,17 @@ export const validateAndResolveBindings = (
}

parsedSettingsByDefName.set(defName, parsedPayload.data);

const actionSchema = defDefinition.action
? actions?.[defDefinition.action]?.settingSchema
: undefined;
const actionParsed = actionSchema?.safeParse(defDefinition.settings);

if (actionParsed && !actionParsed.success) {
issues.push(
...toBindingSettingsIssues(actionParsed.error.issues, defName),
);
}
}

for (const [defName, defDefinition] of Object.entries(defs)) {
Expand Down
Loading