fix: correct isAuthorizedRaw return type from (int64,bool) to (bool) - #131
Closed
Yonkoo11 wants to merge 1 commit into
Closed
fix: correct isAuthorizedRaw return type from (int64,bool) to (bool)#131Yonkoo11 wants to merge 1 commit into
Yonkoo11 wants to merge 1 commit into
Conversation
Signed-off-by: yonkoo11 <alexmustapha11@gmail.com>
Yonkoo11
force-pushed
the
fix/isAuthorizedRaw-return-type
branch
from
July 25, 2026 23:23
0263823 to
3b36b7d
Compare
Author
|
Friendly follow-up: DCO and the available checks are green. This keeps the ABI aligned with the HIP-719 isAuthorizedRaw boolean return type; happy to adjust anything needed for review. |
ValentinVPK
approved these changes
Aug 3, 2026
ValentinVPK
left a comment
ValentinVPK
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you for your contribution!
Member
|
Closing in favour of #142. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126
The precompile for
isAuthorizedRawreturns a bareBOOL(bool), notRESPONSE_CODE64_BOOL(int64, bool). This was verified against the consensus node across all IHRC632 functions — onlyisAuthorizedRawhad the mismatch (see issue #126 for the full comparison table).This PR:
(int64 responseCode, bool authorized)to(bool authorized)isAuthorizedEDCSA→ECDSAtypo in the same doc comment