fix: correct isAuthorizedRaw return type to (bool) - #142
Merged
natanasow merged 2 commits intoAug 21, 2026
Merged
Conversation
Signed-off-by: ValentinVPK <valentin.krumov@limechain.tech>
…urn-only-bool Signed-off-by: ValentinVPK <valentin.krumov@limechain.tech>
natanasow
approved these changes
Aug 21, 2026
Contributor
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the isAuthorizedRaw return type from (int64 responseCode, bool authorized) to (bool authorized) across the raw-precompile interfaces (IHRC632.sol and IHederaAccountService.sol), matching the actual precompile ABI — verified against the consensus node's own IHederaAccountService.sol, which declares isAuthorizedRaw(...) returns (bool response). Also updates the HAS README.md signature table and fixes the EDCSA → ECDSA NatSpec typo, while intentionally leaving the HederaAccountService.sol wrapper returning (int64, bool) since it synthesizes a responseCode from the low-level call's success and AliasAccountUtility plus the tests rely on that.
Fixes #126.