Skip to content

refactor: use strings.builder - #1488

Closed
mickychang9 wants to merge 1 commit into
hiero-ledger:mainfrom
mickychang9:main
Closed

refactor: use strings.builder#1488
mickychang9 wants to merge 1 commit into
hiero-ledger:mainfrom
mickychang9:main

Conversation

@mickychang9

Copy link
Copy Markdown
Contributor

Description:

strings.Builder has fewer memory allocations and better performance.
More info: golang/go#75190

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: mickychang9 <mickychang9@outlook.com>
@mickychang9
mickychang9 requested review from a team as code owners September 11, 2025 11:18
@lfdt-bot

Copy link
Copy Markdown

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@codecov

codecov Bot commented Sep 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sdk/custom_fee_limit.go 83.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
sdk/abi_decode.go 58.51% <100.00%> (+0.14%) ⬆️
sdk/node_address.go 50.00% <100.00%> (ø)
sdk/token_nft_allowance.go 96.66% <100.00%> (ø)
sdk/custom_fee_limit.go 89.09% <83.33%> (+0.20%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xivanov 0xivanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mickychang9 !

@0xivanov

Copy link
Copy Markdown
Contributor

Seems like the commit is not signed, so unable to merge.

@0xivanov 0xivanov closed this Sep 23, 2025
@mickychang9 mickychang9 mentioned this pull request Sep 29, 2025
2 tasks
@mickychang9

Copy link
Copy Markdown
Contributor Author

Seems like the commit is not signed, so unable to merge.

Sorry for the delay. The new signed pr: #1508

Please review again when you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants