Skip to content

refactor: use strings.builder #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mickychang9 wants to merge 1 commit into from
Closed

refactor: use strings.builder #1488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions sdk/abi_decode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,19 +183,20 @@ func (a Address) checksumEncode() string {

hash := hex.EncodeToString(Keccak256Hash([]byte(address)).Bytes())

ret := "0x"
var ret strings.Builder
ret.WriteString("0x")
for i := 0; i < len(address); i++ {
character := string(address[i])

num, _ := strconv.ParseInt(string(hash[i]), 16, 64)
if num > 7 {
ret += strings.ToUpper(character)
ret.WriteString(strings.ToUpper(character))
} else {
ret += character
ret.WriteString(character)
}
}

return ret
return ret.String()
}

func readAddr(b []byte) (Address, error) {
Expand Down
13 changes: 8 additions & 5 deletions sdk/custom_fee_limit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package hiero

import "strings"

import "github.com/hiero-ledger/hiero-sdk-go/v2/proto/services"

// SPDX-License-Identifier: Apache-2.0
Expand Down Expand Up @@ -83,13 +85,14 @@ func (feeLimit *CustomFeeLimit) toProtobuf() *services.CustomFeeLimit {
}

func (feeLimit *CustomFeeLimit) String() string {
customFeesStr := "["
var customFeesStr strings.Builder
customFeesStr.WriteString("[")
for i, fee := range feeLimit.CustomFees {
if i > 0 {
customFeesStr += ", "
customFeesStr.WriteString(", ")
}
customFeesStr += fee.String()
customFeesStr.WriteString(fee.String())
}
customFeesStr += "]"
return "CustomFeeLimit{PayerId: " + feeLimit.PayerId.String() + ", CustomFees: " + customFeesStr + "}"
customFeesStr.WriteString("]")
return "CustomFeeLimit{PayerId: " + feeLimit.PayerId.String() + ", CustomFees: " + customFeesStr.String() + "}"
}
7 changes: 4 additions & 3 deletions sdk/node_address.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package hiero

import (
"strconv"
"strings"

"github.com/hiero-ledger/hiero-sdk-go/v2/proto/services"
)
Expand Down Expand Up @@ -60,9 +61,9 @@ func (nodeAdd *NodeAddress) _ToProtobuf() *services.NodeAddress {

// String returns a string representation of the NodeAddress
func (nodeAdd NodeAddress) String() string {
Addresses := ""
var Addresses strings.Builder
for _, k := range nodeAdd.Addresses {
Addresses += k.String()
Addresses.WriteString(k.String())
}
return "NodeAccountId: " + nodeAdd.AccountID.String() + " " + Addresses + "\n" + "CertHash: " + string(nodeAdd.CertHash) + "\n" + "NodeId: " + strconv.FormatInt(nodeAdd.NodeID, 10) + "\n" + "PubKey: " + nodeAdd.PublicKey
return "NodeAccountId: " + nodeAdd.AccountID.String() + " " + Addresses.String() + "\n" + "CertHash: " + string(nodeAdd.CertHash) + "\n" + "NodeId: " + strconv.FormatInt(nodeAdd.NodeID, 10) + "\n" + "PubKey: " + nodeAdd.PublicKey
}
7 changes: 4 additions & 3 deletions sdk/token_nft_allowance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package hiero

import (
"fmt"
"strings"

"github.com/hiero-ledger/hiero-sdk-go/v2/proto/services"
"google.golang.org/protobuf/types/known/wrapperspb"
Expand Down Expand Up @@ -118,7 +119,7 @@ func (approval *TokenNftAllowance) String() string {
var owner string
var spender string
var token string
var serials string
var serials strings.Builder

if approval.OwnerAccountID != nil {
owner = approval.OwnerAccountID.String()
Expand All @@ -133,8 +134,8 @@ func (approval *TokenNftAllowance) String() string {
}

for _, serial := range approval.SerialNumbers {
serials += fmt.Sprintf("%d, ", serial)
serials.WriteString(fmt.Sprintf("%d, ", serial))
}

return fmt.Sprintf("OwnerAccountID: %s, SpenderAccountID: %s, TokenID: %s, Serials: %s, ApprovedForAll: %t", owner, spender, token, serials, approval.AllSerials)
return fmt.Sprintf("OwnerAccountID: %s, SpenderAccountID: %s, TokenID: %s, Serials: %s, ApprovedForAll: %t", owner, spender, token, serials.String(), approval.AllSerials)
}
Loading