fix(sdk): correct panic message in TokenSupplyType.String() and add unit test - #1756
Closed
AruneshDwivedi wants to merge 1 commit into
Closed
Conversation
…nit test Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Dosik13
reviewed
Jul 7, 2026
| for _, tt := range tests { | ||
| assert.Equal(t, tt.expected, tt.supplyType.String()) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Could you add a panic-path test? PanicsWithValue asserts the exact message, so it covers the branch actually changed and would've failed on the old TokenType.String() text.
Contributor
|
Due to inactivity I am closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TokenSupplyType.String() panic message says TokenType.String() — copy-paste from token_type.go. Corrected to reference TokenSupplyType.
Table-driven test asserts the string mapping for both INFINITE and FINITE values.