Skip to content

fix(sdk): correct panic message in TokenSupplyType.String() and add unit test #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AruneshDwivedi wants to merge 1 commit into from
+28 −1
Closed

fix(sdk): correct panic message in TokenSupplyType.String() and add unit test #1756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/token_supply_type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ func (tokenSupplyType TokenSupplyType) String() string {
return "TOKEN_SUPPLY_TYPE_FINITE"
}

panic(fmt.Sprintf("unreachable: TokenType.String() switch statement is non-exhaustive. Status: %v", uint32(tokenSupplyType)))
panic(fmt.Sprintf("unreachable: TokenSupplyType.String() switch statement is non-exhaustive. Status: %v", uint32(tokenSupplyType)))
}
27 changes: 27 additions & 0 deletions sdk/token_supply_type_unit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
//go:build all || unit

package hiero

// SPDX-License-Identifier: Apache-2.0

import (
"testing"

"github.com/stretchr/testify/assert"
)

func TestUnitTokenSupplyTypeString(t *testing.T) {
t.Parallel()

tests := []struct {
supplyType TokenSupplyType
expected string
}{
{TokenSupplyTypeInfinite, "TOKEN_SUPPLY_TYPE_INFINITE"},
{TokenSupplyTypeFinite, "TOKEN_SUPPLY_TYPE_FINITE"},
}

for _, tt := range tests {
assert.Equal(t, tt.expected, tt.supplyType.String())
}
}

@Dosik13 Dosik13 Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a panic-path test? PanicsWithValue asserts the exact message, so it covers the branch actually changed and would've failed on the old TokenType.String() text.

Loading