Add volume assistant sensor - #7078
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new assistant volume sensor to the Companion App’s audio sensor set, and wires it into the existing volume-change broadcast handling so the sensor can update when volume changes occur.
Changes:
- Add a new
volume_assistantBasicSensortoAudioSensorManager, including its strings and icon - Update
SensorReceivermappings (mobile + wear) so volume-change intents can trigger assistant volume updates - Extend audio mode state mapping to include
MODE_ASSISTANT_CONVERSATION
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| wear/src/main/kotlin/io/homeassistant/companion/android/sensors/SensorReceiver.kt | Adds volAssistant to the wear volume-change sensor mapping |
| common/src/main/res/values/strings.xml | Adds name/description strings for the new assistant volume sensor |
| common/src/main/kotlin/io/homeassistant/companion/android/common/sensors/AudioSensorManager.kt | Introduces volAssistant, adds availability/update gating, and extends audio mode mapping |
| app/src/main/kotlin/io/homeassistant/companion/android/sensors/SensorReceiver.kt | Adds volAssistant to the mobile volume-change sensor mapping |
TimoPtr
force-pushed
the
feature/assistant_volume_cmd
branch
from
June 24, 2026 06:41
b806e8b to
e9873e0
Compare
TimoPtr
force-pushed
the
feature/assistant_volume_sensor
branch
from
June 24, 2026 06:47
52b95fc to
0c7ae12
Compare
TimoPtr
changed the base branch from
feature/assistant_volume_cmd
to
feature/sensor_managers_injectable
June 24, 2026 06:48
TimoPtr
force-pushed
the
feature/sensor_managers_injectable
branch
from
June 25, 2026 15:11
5c5a9de to
6815184
Compare
TimoPtr
force-pushed
the
feature/assistant_volume_sensor
branch
from
June 25, 2026 15:11
0c7ae12 to
f2f54a5
Compare
TimoPtr
force-pushed
the
feature/sensor_managers_injectable
branch
from
June 25, 2026 15:29
6815184 to
f3dd9fd
Compare
TimoPtr
force-pushed
the
feature/assistant_volume_sensor
branch
from
June 25, 2026 15:30
f2f54a5 to
bce7346
Compare
Contributor
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 5d05a44. ♻️ This comment has been updated with latest results. |
jpelgrom
approved these changes
Jun 28, 2026
jpelgrom
left a comment
jpelgrom
left a comment
Member
There was a problem hiding this comment.
One very minor suggestion and one comment on the state of icons, but the actual change is good!
| "sensor", | ||
| commonR.string.sensor_name_volume_assistant, | ||
| commonR.string.sensor_description_volume_assistant, | ||
| "mdi:assistant", |
Member
There was a problem hiding this comment.
This is quite different from what Android uses - the correct icon appears to be Voice Chat, but MDI hasn't updated in a long time and appears to be basically dead :-/
Member
Author
There was a problem hiding this comment.
by MDI hasn't updated you mean a lib we use or something else?
Member
There was a problem hiding this comment.
The lib we, but more importantly, core uses for icons https://pictogrammers.com/library/mdi/
TimoPtr
force-pushed
the
feature/sensor_managers_injectable
branch
from
June 29, 2026 10:35
f3dd9fd to
bbdf55b
Compare
TimoPtr
force-pushed
the
feature/assistant_volume_sensor
branch
from
June 29, 2026 10:35
bce7346 to
5d05a44
Compare
TimoPtr
force-pushed
the
feature/sensor_managers_injectable
branch
from
June 29, 2026 11:42
bbdf55b to
15ba358
Compare
TimoPtr
force-pushed
the
feature/assistant_volume_sensor
branch
3 times, most recently
from
June 29, 2026 14:14
21ab925 to
7dccab6
Compare
TimoPtr
force-pushed
the
feature/sensor_managers_injectable
branch
from
June 30, 2026 07:56
7032c01 to
3088dc4
Compare
TimoPtr
force-pushed
the
feature/assistant_volume_sensor
branch
from
June 30, 2026 07:57
a2055cf to
75ed143
Compare
TimoPtr
force-pushed
the
feature/assistant_volume_sensor
branch
from
June 30, 2026 12:49
75ed143 to
3437d5c
Compare
TimoPtr
enabled auto-merge (squash)
June 30, 2026 12:50
auto-merge was automatically disabled
June 30, 2026 13:02
Pull request was closed
TimoPtr
enabled auto-merge (squash)
June 30, 2026 13:02
TimoPtr
disabled auto-merge
June 30, 2026 13:31
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the volume assistant sensor when available (Android 17+)
Checklist
Link to pull request in documentation repositories
User Documentation: home-assistant/companion.home-assistant#1356