Disable heatmiser integration - #157816
Conversation
home-assistant
Bot
added
breaking-change
cla-signed
integration: heatmiser
small-pr
|
Hey there @andylockran, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
This PR disables the heatmiser integration due to its dependency on pyserial-asyncio, which performs blocking I/O operations in the asyncio event loop and is no longer maintained. This is a breaking change that will prevent users from using this integration.
Key Changes
- Added a
disabledfield to the manifest.json explaining why the integration is disabled - Removed the heatmiserV3 dependency from requirements_all.txt
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| homeassistant/components/heatmiser/manifest.json | Added disabled field with explanation for disabling the integration |
| requirements_all.txt | Removed heatmiserV3==2.0.3 dependency from the global requirements list |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Looking at the installation usage for this integration and the issues I think this integration can be removed |
|
The linked PR is from 2024. Why do we need to disable them now? Has something changed recently that we need to act now? |
It has been actively worked on since May - all other integrations and dependencies have been updated. |
I think that we have huge benefit from dropping |
|
Yeah, I've moved out of the house that had the physical devices so have no
testing capability any more. I've tried to find a maintainer but none are
forthcoming. If you've any tips on how to hand this over please let me
know, else I agree with it being disabled and removed.
…On Wed, 3 Dec 2025, 18:51 Shay Levy, ***@***.***> wrote:
*thecode* left a comment (home-assistant/core#157816)
<#157816 (comment)>
The linked PR is from 2024. Why do we need to disable them now? Has
something changed recently that we need to act now?
I think that we have huge benefit from dropping pyserial and switching to
pyserial-asyncio, this platform for example has 5 active installations,
but if you actually look at the issues there are issues since 2019 (and
there is no GitHub history before that) that it is not working, which is
why I suggested to remove it completely and not just disable which will
need a future PR to cleanup anyhow. Similar situation for #157817
<#157817>
—
Reply to this email directly, view it on GitHub
<#157816 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKY334FK35O7XWFLMOPOUD374WJRAVCNFSM6AAAAACN4NKF72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMBYGMYTSNBZGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
The confusing part is that pyserial-asyncio is referenced, but doesn't seem used at all in the code. So just removing the reference should be fine (see library PR andylockran/heatmiserV3#98) |
|
For reference:
|
Also, it is easier to disable/enable than remove/re-add if someone is willing to take over the integration. |
|
closing in favour of #158304 |
Breaking change
This integration is disabled because it references pyserial-asyncio, which does blocking I/O in the asyncio loop and is not maintained.
Proposed change
Linked to #116635
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: