Skip to content

Disable blackbird integration - #157817

Merged
epenet merged 3 commits into
devfrom
epenet-20251203-0935
Dec 18, 2025
Merged

Disable blackbird integration#157817
epenet merged 3 commits into
devfrom
epenet-20251203-0935

Conversation

@epenet

@epenet epenet commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Breaking change

This integration is disabled because it references pyserial-asyncio, which does blocking I/O in the asyncio loop and is not maintained.

Proposed change

Linked to #116635

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables the blackbird integration due to its dependency on pyserial-asyncio, which performs blocking I/O operations in the asyncio event loop and is no longer maintained. This is a breaking change that prevents the integration from loading while preserving the code for potential future fixes.

Key Changes

  • Added disabled field to manifest.json explaining why the integration is disabled
  • Removed pyblackbird dependency from requirements_all.txt and requirements_test_all.txt
  • Added test configuration to ignore all test files for the disabled integration

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/blackbird/manifest.json Added disabled field with explanation for disabling the integration
tests/components/blackbird/conftest.py Added pytest configuration to ignore all test files for the disabled integration
requirements_all.txt Removed pyblackbird dependency as integration is disabled
requirements_test_all.txt Removed pyblackbird test dependency as integration is disabled

Comment thread homeassistant/components/blackbird/manifest.json
@thecode

thecode commented Dec 3, 2025

Copy link
Copy Markdown
Member

Looking at the installation usage for this integration and the issues I think this integration can be removed

@edenhaus

edenhaus commented Dec 3, 2025

Copy link
Copy Markdown
Member

Drafting it until comments from the other PRs (#157816, #157816) are sorted out

@edenhaus
edenhaus marked this pull request as draft December 3, 2025 09:53
@epenet

epenet commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

Drafting it until comments from the other PRs (#157816, #157816) are sorted out

It has been actively worked on since May - all other integrations and dependencies have been updated.
If we don't act now - then when?

@thecode thecode mentioned this pull request Dec 3, 2025
21 tasks
@epenet

epenet commented Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

@epenet

epenet commented Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

Drafting it until comments from the other PRs (#157816, #157816) are sorted out

It has been actively worked on since May - all other integrations and dependencies have been updated. If we don't act now - then when?

Also, it is easier to disable/enable than remove/re-add if someone is willing to take over the integration.

@epenet
epenet marked this pull request as ready for review December 16, 2025 10:39
@epenet

epenet commented Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

Drafting it until comments from the other PRs (#157816, #157818) are sorted out

#157816 and #157818 have been replaced by library bumps.

That makes this the only blocking PR for #116635

@bdraco

bdraco commented Dec 18, 2025

Copy link
Copy Markdown
Member

Looks like the only activity on the lib was from issue koolsb/pyblackbird#7 and that was 2 years ago.

@epenet
epenet merged commit e5a73fc into dev Dec 18, 2025
67 checks passed
@epenet
epenet deleted the epenet-20251203-0935 branch December 18, 2025 07:51
epenet added a commit that referenced this pull request Dec 18, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants