DWX-20746: Onboard JPMC to CDW - remove AES encryption for AddFileToS3#15590
Open
architlatkar27 wants to merge 1 commit into
Open
DWX-20746: Onboard JPMC to CDW - remove AES encryption for AddFileToS3#15590architlatkar27 wants to merge 1 commit into
architlatkar27 wants to merge 1 commit into
Conversation
…CF templates to buckets with SSE-CMK enabled
| "kms:PutKeyPolicy", | ||
| "kms:ScheduleKeyDeletion" | ||
| "kms:ScheduleKeyDeletion", | ||
| "kms:GenerateDataKey" |
Contributor
There was a problem hiding this comment.
Don't you need to add it in aws-environment-minimal-policy.json and aws-gov-environment-minimal-policy.json as well?
Author
There was a problem hiding this comment.
I went over the other policies in this repo, I think we would need to add it to aws-gov-cb-policy.json. Also, would the minimal policies be able to run any dataservices without IAM issues? For example we have minimal policies in CDW but they work only in CDW.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add kms:GenerateDataKey permission to KMS key so that CDW can upload CF templates to buckets with SSE-CMK enabled