Skip to content

DWX-20746: Onboard JPMC to CDW - remove AES encryption for AddFileToS3 #15590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
architlatkar27 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

DWX-20746: Onboard JPMC to CDW - remove AES encryption for AddFileToS3 #15590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cloud-aws-common/src/main/resources/definitions/aws-cb-policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,8 @@
"kms:TagResource",
"kms:DeleteAlias",
"kms:PutKeyPolicy",
"kms:ScheduleKeyDeletion"
"kms:ScheduleKeyDeletion",
"kms:GenerateDataKey"

@adarshsharma1983 adarshsharma1983 May 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to add it in aws-environment-minimal-policy.json and aws-gov-environment-minimal-policy.json as well?

@architlatkar27 architlatkar27 May 22, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went over the other policies in this repo, I think we would need to add it to aws-gov-cb-policy.json. Also, would the minimal policies be able to run any dataservices without IAM issues? For example we have minimal policies in CDW but they work only in CDW.

],
"Effect": "Allow",
"Resource": [
Expand Down