Removes unnecessary bang on Bclose command#20
Open
michael-wojcik wants to merge 1 commit intoiberianpig:masterfrom
Open
Removes unnecessary bang on Bclose command#20michael-wojcik wants to merge 1 commit intoiberianpig:masterfrom
michael-wojcik wants to merge 1 commit intoiberianpig:masterfrom
Conversation
Owner
|
Thanks for creating pull request! |
iberianpig
reviewed
Jun 22, 2020
| if a:exit_code == 0 | ||
| if has('nvim') | ||
| silent! Bclose! | ||
| silent! Bclose |
Owner
There was a problem hiding this comment.
On NeoVim, Bclose remains read-only buffers after do tig_callback
:buffers
3 %a "autoload/tig_explorer.vim" line 141
4 #h- "term://.//23306:TIGRC_USER=/tmp/nvimSwU80w/3 tig status" line 39
Owner
There was a problem hiding this comment.
On SpaceVim, could you work the following workaround instead of silent! Bclose!?
Suggested change
| silent! Bclose | |
| silent! buffer # | bwipeout! # |
iberianpig
requested changes
Jun 22, 2020
| if a:exit_code == 0 | ||
| if has('nvim') | ||
| silent! Bclose! | ||
| silent! Bclose |
Owner
There was a problem hiding this comment.
On SpaceVim, could you work the following workaround instead of silent! Bclose!?
Suggested change
| silent! Bclose | |
| silent! buffer # | bwipeout! # |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using SpaceVim and ran into an error where it's custom
close_term_bufferfunction would throw an error each time I attempted to edit a file from withintig-explorer.vim:This was being thrown because
s:tig_callbackadds a bang to the Bclose command on Line 140. AFAIK, adding a bang here seems unnecessary and can cause conflicts with other window/buffer managers like the example above. By removing the bang from that one line, I am able to edit files fromtig-explorer.vimwithout any errors.BTW, thanks very much for providing the
tig-explorer.vimplugin! It's really great to have the option of using Tig inside Vim! 🙏