IBX-10428: Fixed invokable commands failing to compile Container - #634
Conversation
4bba6bd to
accacab
Compare
|
If we want, we could add a dummy invokable command to integration tests to ensure that they can be registered properly, but we don't have precedence yet as to where to put things like that. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a compilation issue where Symfony's invokable commands (commands without explicit class definitions) were causing container build failures when the compiler pass attempted to add siteaccess options to them.
- Added class validation to skip invokable commands in the ConsoleCommandPass
- Updated test to properly define Command class for existing test case
- Added new test to verify invokable commands are properly skipped
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/bundle/Core/DependencyInjection/Compiler/ConsoleCommandPass.php | Added validation to skip commands without explicit Command class definitions |
| tests/bundle/Core/DependencyInjection/Compiler/ConsoleCommandPassTest.php | Updated existing test and added test case for invokable command handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|



Description:
This fix allows invokable commands from Symfony to work properly and not crash the application.
For QA:
Documentation: