Skip to content

IBX-10428: Fixed invokable commands failing to compile Container #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamwojs merged 3 commits into from
Aug 14, 2025
Merged

IBX-10428: Fixed invokable commands failing to compile Container #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
accacab
IBX-10428: Fixed invokable commands failing to compile Container
Steveb-p Aug 13, 2025
326c06a
IBX-10428: Fixed invokable commands failing to compile Container
Steveb-p Aug 13, 2025
eea4606
IBX-10428: Fixed invokable commands failing to compile Container
Steveb-p Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/bundle/Core/DependencyInjection/Compiler/ConsoleCommandPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

namespace Ibexa\Bundle\Core\DependencyInjection\Compiler;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
Expand All @@ -19,6 +20,11 @@ public function process(ContainerBuilder $container): void
foreach ($container->findTaggedServiceIds('console.command') as $id => $attributes) {
$definition = $container->getDefinition($id);

$class = $definition->getClass();
if ($class === null || !is_a($class, Command::class, true)) {
Comment thread
Steveb-p marked this conversation as resolved.
continue;
}

$definition->addMethodCall('addOption', [
'siteaccess',
null,
Expand Down
15 changes: 14 additions & 1 deletion tests/bundle/Core/DependencyInjection/Compiler/ConsoleCommandPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

use Ibexa\Bundle\Core\DependencyInjection\Compiler\ConsoleCommandPass;
use Matthias\SymfonyDependencyInjectionTest\PhpUnit\AbstractCompilerPassTestCase;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
Expand All @@ -23,7 +24,7 @@ protected function registerCompilerPass(ContainerBuilder $container): void

public function testAddSiteaccessOption(): void
{
$commandDefinition = new Definition();
$commandDefinition = new Definition(Command::class);
$serviceId = 'some_service_id';
$commandDefinition->addTag('console.command');

Expand All @@ -41,4 +42,16 @@ public function testAddSiteaccessOption(): void
]
);
}

public function testSkipsSiteaccessOptionOnInvokables(): void
{
$commandDefinition = new Definition();
$serviceId = 'some_service_id';
$commandDefinition->addTag('console.command');

$this->setDefinition($serviceId, $commandDefinition);
$this->compile();

$this->assertContainerBuilderHasService($serviceId);
}
}
Loading