Skip to content

Fix/2068#307

Open
conradmugabe wants to merge 4 commits into
mainfrom
fix/2068
Open

Fix/2068#307
conradmugabe wants to merge 4 commits into
mainfrom
fix/2068

Conversation

@conradmugabe

Copy link
Copy Markdown
Contributor

Checklist

  • Tests were added/updated according to the feature/bugfix/change made
  • Version was rolled according to semver requirements
  • API endpoints openapi schema was updated if applicable

Changes

conradmugabe and others added 4 commits July 4, 2026 06:56
Pulls in the enable_chat_history_export tenant setting (via
@iblai/web-utils) that the chat-history export gate reads.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011tT29xrvXbGyeuokaWsPTg
Gate the chat-history export menu item on the new
enable_chat_history_export tenant setting combined with the user's
role: non-students always keep export; students lose it only when a
tenant admin turns the setting off (default on). Reads the setting via
useTenantMetadata and threads a canExport flag down to the row menu.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011tT29xrvXbGyeuokaWsPTg
Covers the tenant Advanced 'Chat History Export' switch (default on,
persists) and the sidebar chat-row menu gating: student + setting off
hides export, student + setting on shows it, non-student always sees it.
Adds sidebar page-object helpers for the chat-row three-dot menu. Runs
serial since all cases mutate the same tenant setting.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011tT29xrvXbGyeuokaWsPTg
Adds journey 56 (chat-history-export-toggle) with checkpoints
chexp-01..05 to the e2e coverage manifest and doc.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011tT29xrvXbGyeuokaWsPTg
@conradmugabe conradmugabe self-assigned this Jul 4, 2026
@conradmugabe conradmugabe requested a review from mamigot as a code owner July 4, 2026 04:25
@mamigot

mamigot commented Jul 4, 2026

Copy link
Copy Markdown
Member

Claude finished @conradmugabe's task —— View job


E2E Coverage Review

  • Dismiss stale REQUEST_CHANGES reviews
  • Identify changed files
  • Run mechanical coverage check
  • Read coverage state
  • Apply decision logic and post review

Result: ✅ Approved — coverage files are correct and complete. Journey 56 (Chat History Export Toggle) adds 5 checkpoints, improving coverage from 499 → 504. All 25 app routes remain covered (100%).

@mamigot mamigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ E2E Coverage — All Good

New e2e journey (56 — Chat History Export Toggle) is covered and coverage files are up to date.

Verified:

  • e2e/journeys/56-chat-history-export-toggle.spec.ts — 5 checkpoints added
  • e2e/coverage.json — new journey entry with correct sourceFiles and checkpoints
  • e2e/COVERAGE.md — matching [x] checkpoint lines added
  • Coverage improved: 499 → 504 checkpoints (+5), 100% coverage maintained
  • Mechanical check: ✅ passed (exit code 0)

@conradmugabe conradmugabe added the run-tests Trigger PR validation pipeline label Jul 4, 2026
@conradmugabe conradmugabe requested a review from sonegillis1 July 4, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-tests Trigger PR validation pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants