Support SecureRandom strong algorithms in FIPS mode - #446
Support SecureRandom strong algorithms in FIPS mode#446Mohit-Rajbhar100698 wants to merge 1 commit into
Conversation
203ebbe to
4c4013b
Compare
|
Hi @keithc-ca |
2d20881 to
c80738e
Compare
|
Hi @keithc-ca , is there anything left for me to address in this PR? |
|
Yes, I was expecting back-ports of ibmruntimes/openj9-openjdk-jdk#1225 and ibmruntimes/openj9-openjdk-jdk#1232 to be proposed and merged before this. |
Sorry, you're right. I thought the other changes were more independent of this. I'll have another look at this with that in mind. |
|
With my corrected understanding of the relationships between ibmruntimes/openj9-openjdk-jdk#1187, ibmruntimes/openj9-openjdk-jdk#1225 and ibmruntimes/openj9-openjdk-jdk#1232, I think it will be simpler to manage if this is updated so it back-ports all three changes (and makes clear that it back-ports three changes, not just one). |
Just to confirm, are you suggesting that we should have a single backport PR that includes all the changes from #1187, #1225, and #1232, instead of backporting them as three separate PRs? In PR Description we can write
? |
Yes. |
This change overrides the default securerandom.strongAlgorithms configuration used by SecureRandom.getInstanceStrong() when it runs in FIPS mode. This PR also includes two additional backports. One removes the provider-specific condition from the SecureRandom strongAlgorithms test(#1225). The other handles the Windows-specific SecureRandom strongAlgorithms defaults used by the test(#1232). Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>
5b82673 to
7b8aba0
Compare
|
Hi @keithc-ca |
|
Jenkins test sanity alinux jdk21 |
2 participants
This change overrides the default securerandom.strongAlgorithms
configuration used by SecureRandom.getInstanceStrong() when it
runs in FIPS mode.
This PR also includes two additional backports. One removes the
provider-specific condition from the SecureRandom strongAlgorithms
test. The other handles the Windows-specific SecureRandom
strongAlgorithms defaults used by the test.
Back-ported from: #1187 #1225 #1232
Signed-off-by: Mohit Rajbhar mohit.rajbhar@ibm.com