Raw welcome message new#13
Open
akrherz wants to merge 4 commits into
Open
Conversation
added 2 commits
October 30, 2020 10:41
nsobadzhiev
approved these changes
Nov 1, 2020
nsobadzhiev
left a comment
nsobadzhiev
left a comment
There was a problem hiding this comment.
Looks good as far as I remember what I did here. Did you test it?
Member
Author
I did not, my focus was to fix the PR after I rewrote the repo git history. |
guusdk
reviewed
Feb 5, 2021
| <% if (errors.containsKey("missingWelcomeMessage")) { %> | ||
| <span class="jive-error-text"><br><fmt:message key="registration.props.form.welcome_message_missing" /></span> | ||
| <% } %> | ||
| <td width="95%"><textarea cols="45" rows="5" wrap="virtual" name="welcomemessage"><%= welcomeMessage %></textarea></td> |
Member
There was a problem hiding this comment.
These <%= outputs need to be properly escaped, to avoid XSS.
guusdk
reviewed
Feb 5, 2021
guusdk
left a comment
guusdk
left a comment
Member
There was a problem hiding this comment.
The admin console page modifications need some escaping.
A changelog item is also desirable.
Member
Author
|
@nsobadzhiev are you able to address these review changes? You likely will want to create a new branch and redo your commits, or cherry pick my branch commits and then add yours ontop. I can help you with the git commands, if you need help. |
guusdk
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obsoletes #12