fix: copy geometry when geometry is of binary format - #3236
Merged
Conversation
igorDykhta
commented
Nov 4, 2025
igorDykhta
commented
Collaborator
- Implement missing part of Copy Geometry: get feature from a binary geojson
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for parsing WKB (Well-Known Binary) geometry data provided as binary formats (Uint8Array or ArrayBuffer), enabling GeoParquet and similar binary geometry formats to be processed directly in the GeoJSON layer.
- Adds binary geometry parsing using WKBLoader for Uint8Array and ArrayBuffer inputs
- Converts binary geometry to GeoJSON features using the existing loaders.gl pipeline
- Follows the established error handling and normalization patterns in the function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ilyabo
approved these changes
Nov 4, 2025
saymonthnoronha
approved these changes
Nov 4, 2025
ilyabo
pushed a commit
that referenced
this pull request
Nov 25, 2025
* fix: copy geometry when geometry is of binary format Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> * nit Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> --------- Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> Signed-off-by: Ilya Boyandin <ilyabo@gmail.com>
ilyabo
added a commit
that referenced
this pull request
Nov 25, 2025
* fix: copy geometry when geometry is of binary format (#3236) * fix: copy geometry when geometry is of binary format Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> * nit Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> --------- Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> Signed-off-by: Ilya Boyandin <ilyabo@gmail.com> * fix: Allow passing arrow tables to ArrowDataContainer Signed-off-by: Ilya Boyandin <ilyabo@gmail.com> * only add arrowTable prop to CREATE_TABLE_TASK when set Signed-off-by: Ilya Boyandin <ilyabo@gmail.com> --------- Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> Signed-off-by: Ilya Boyandin <ilyabo@gmail.com> Co-authored-by: Igor Dykhta <igorDykhta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.