Skip to content

fix: copy geometry when geometry is of binary format #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorDykhta merged 2 commits into from
Nov 4, 2025
Merged

fix: copy geometry when geometry is of binary format #3236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
425c7e6
fix: copy geometry when geometry is of binary format
igorDykhta Nov 3, 2025
2bc0e4f
nit
igorDykhta Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/layers/src/geojson-layer/geojson-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,28 @@ export function fieldIsGeoArrow(geoField?: ProtoDatasetField | null): boolean {

export function parseGeoJsonRawFeature(rawFeature: unknown): Feature | null {
const properties = null; // help ensure that properties is present on the returned geojson feature
// Support WKB geometry provided as binary (e.g., from Parquet/GeoParquet)
if (rawFeature instanceof Uint8Array || rawFeature instanceof ArrayBuffer) {
try {
const binaryInput =
rawFeature instanceof ArrayBuffer
? rawFeature
: (rawFeature as Uint8Array).buffer.slice(
(rawFeature as Uint8Array).byteOffset,
(rawFeature as Uint8Array).byteOffset + (rawFeature as Uint8Array).byteLength
);
const binaryGeo = parseSync(binaryInput as ArrayBuffer, WKBLoader);
// @ts-expect-error loaders.gl binary type to GeoJSON geometry
const parsedGeo = binaryToGeometry(binaryGeo);
const normalized = normalize(parsedGeo);
if (!normalized || !Array.isArray(normalized.features) || !normalized.features.length) {
return null;
}
return {properties, ...normalized.features[0]};
} catch (e) {
return null;
}
}
if (typeof rawFeature === 'object') {
// Support GeoJson feature as object
// probably need to normalize it as well
Expand Down