Compute props through the data store - #807
Open
pleek91 wants to merge 2 commits into
Open
Conversation
pleek91
force-pushed
the
props-on-data-store
branch
2 times, most recently
from
August 1, 2026 04:58
81e3580 to
a1db7d7
Compare
pleek91
force-pushed
the
props-on-data-store
branch
13 times, most recently
from
August 3, 2026 05:06
2dd40c1 to
4ddf4aa
Compare
pleek91
force-pushed
the
props-on-data-store
branch
5 times, most recently
from
August 3, 2026 05:28
2d124e1 to
41916dc
Compare
pleek91
force-pushed
the
props-on-data-store
branch
3 times, most recently
from
August 3, 2026 05:49
03c097e to
e8a0954
Compare
pleek91
force-pushed
the
props-on-data-store
branch
from
August 3, 2026 05:51
e8a0954 to
53f141a
Compare
Props move onto scopes: a link computes into its own, hands it to the navigation when followed, and drops it otherwise. A getter waiting on its parent awaits a value rather than watching for one to appear, so the waiter machinery, its detached effect scope, and the batch threaded through the parent context all go away. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
pleek91
force-pushed
the
props-on-data-store
branch
from
August 3, 2026 05:58
53f141a to
b327516
Compare
stackoverfloweth
approved these changes
Aug 6, 2026
stackoverfloweth
left a comment
Member
There was a problem hiding this comment.
left some small suggestions in a commit, love how much this simplifies the prefetching. The props store changes are pretty sweeping and hard to really grok fully but I like what I see
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Second step of #805, stacked on #806. No behaviour changes — every existing test passes unchanged.
Props move onto the store added in #806, one store per navigation. A link prefetches into its own store and stages it when followed; the navigation it triggers adopts that store, and the one it replaces is disposed outright rather than picked over for entries the new route still needs.
A getter waiting on its parent now awaits a value rather than watching for one to appear:
That removes the waiter machinery entirely — the detached effect scope, the watch handles, and the bookkeeping to discard them. Prefetch strategies also stop being separate buckets, so a value prefetched on render is visible to a getter that runs on hover without being passed along explicitly.