Add comprehensive tests for no reindexing logic#66
Open
krshrimali wants to merge 2 commits into
Open
Conversation
- Implemented a thorough test for ensuring files are not reindexed unnecessarily unless modified. - Refactored and optimized database path normalization and relative path handling. - Simplified JSON parsing and error handling in database mappings. - Improved indexing metadata creation and validation. - Enhanced test coverage for multi-commit scenarios.
- Updated database path construction to use `std::path::MAIN_SEPARATOR` and `to_string_lossy` for better cross-platform compatibility. - Enhanced debugging messages for clearer indexing and path handling insights. - Simplified commit matching logic and indexing path determination.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces extensive tests to ensure files are not reindexed unnecessarily unless there are modifications. Key updates include:
These changes aim to improve the efficiency and reliability of the reindexing mechanism.