Skip to content

Add comprehensive tests for no reindexing logic #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krshrimali wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add comprehensive tests for no reindexing logic #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7d62c6
Add comprehensive tests for no reindexing logic
krshrimali Jul 5, 2025
37fe569
Refactor database path handling and improve debugging output
krshrimali Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
161 changes: 143 additions & 18 deletions src/algo_loc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,48 +4,173 @@ use crate::{
config, contextgpt_structs::AuthorDetailsV2, git_command_algo::extract_details_parallel,
};
use std::collections::HashMap;
use std::path::PathBuf;

pub async fn perform_for_whole_file(
origin_file_path: String,
should_print: bool,
commits_to_index: Option<Vec<String>>,
workspace_path: Option<String>,
) -> HashMap<u32, AuthorDetailsV2> {
// First check if we need to perform indexing at all
if workspace_path.is_some() {
if let Some(workspace) = workspace_path.as_ref() {
match get_latest_commit(&origin_file_path) {
Some(recent_commit) => {
// Check if the file exists in indexing metadata
let db_folder =
format!("{}/{}", config::DB_FOLDER, workspace_path.unwrap().clone());
if let Some(home) = simple_home_dir::home_dir() {
let folder_path = home.join(db_folder);
if let Some(path_str) = folder_path.to_str() {
let indexing_path = format!("{}/indexing_metadata.json", path_str);
if std::path::Path::new(&indexing_path).exists() {
let workspace_path_buf = PathBuf::from(workspace);
let workspace_name = workspace_path_buf
.file_name()
.and_then(|name| name.to_str())
.unwrap_or("default_workspace");

println!(
"DEBUG: Workspace name: {}",
workspace_path_buf.to_string_lossy()
);
let db_folder = format!(
"{}{}{}{}{}",
home.to_string_lossy(),
std::path::MAIN_SEPARATOR,
config::DB_FOLDER,
std::path::MAIN_SEPARATOR,
workspace_path_buf.to_string_lossy().to_string()
);

if let path_str = db_folder.to_string() {
// let indexing_path = db_folder.join(path_str).join("indexing_metadata.json");
let indexing_path = format!(
"{}{}indexing_metadata.json",
path_str,
std::path::MAIN_SEPARATOR
);

if PathBuf::from(indexing_path.clone()).exists() {
match std::fs::read_to_string(&indexing_path) {
Ok(metadata_str) => {
match serde_json::from_str::<HashMap<String, Vec<String>>>(
&metadata_str,
) {
Ok(indexing_metadata) => {
if let Some(last_indexing_data) =
indexing_metadata.get(&origin_file_path)
// Normalize paths for proper comparison
let origin_path_buf = PathBuf::from(&origin_file_path);
let workspace_path_buf = PathBuf::from(workspace);

// Try to canonicalize both paths for accurate comparison
let canonical_origin = origin_path_buf
.canonicalize()
.unwrap_or(origin_path_buf.clone());
let canonical_workspace = workspace_path_buf
.canonicalize()
.unwrap_or(workspace_path_buf.clone());

let relative_path = if let Ok(rel) =
canonical_origin.strip_prefix(&canonical_workspace)
{
if let Some(last_indexed_commit) =
last_indexing_data.last()
rel.to_string_lossy().replace('\\', "/")
} else {
// Fallback: try without canonicalization
if let Ok(rel) = origin_path_buf
.strip_prefix(&workspace_path_buf)
{
if last_indexed_commit == &recent_commit {
if should_print {
rel.to_string_lossy().replace('\\', "/")
} else {
// Last resort: use filename
origin_path_buf
.file_name()
.map(|name| {
name.to_string_lossy().to_string()
})
.unwrap_or_else(|| origin_file_path.clone())
}
};

// Check if file is already indexed with latest commit
// Try different path variations to find existing metadata
let possible_paths = vec![
origin_file_path.clone(),
if let Ok(canonical) =
PathBuf::from(&origin_file_path).canonicalize()
{
canonical.to_string_lossy().to_string()
} else {
origin_file_path.clone()
},
relative_path.clone(),
];

println!(
"DEBUG: Checking if file is already indexed with latest commit: {}",
recent_commit
);
println!("DEBUG: Possible paths to check:");
for (i, path) in possible_paths.iter().enumerate() {
println!("DEBUG: {}: {}", i, path);
}

for path_variant in possible_paths {
println!(
"DEBUG: Checking path variant: {}",
path_variant
);
if let Some(last_indexing_data) =
indexing_metadata.get(&path_variant)
{
println!(
"DEBUG: Found indexing data for path: {}",
path_variant
);
println!(
"DEBUG: Last indexing data: {:?}",
last_indexing_data
);

if let Some(last_indexed_commit) =
last_indexing_data.last()
{
println!(
"DEBUG: Last indexed commit: {}",
last_indexed_commit
);

if last_indexed_commit == &recent_commit {
println!(
"DEBUG: Commit matches! No reindexing needed."
);
if should_print {
println!(
"File {} is already indexed with the latest commit {}",
path_variant, recent_commit
);
}
return HashMap::new();
} else {
println!(
"File {} is already indexed with the latest commit {}",
origin_file_path, recent_commit
"DEBUG: Commit doesn't match. Reindexing needed."
);
if should_print {
println!(
"File {} has a new commit {} (last indexed: {})",
path_variant,
recent_commit,
last_indexed_commit
);
}
}
return HashMap::new();
} else {
println!(
"DEBUG: No last indexed commit found."
);
}
} else {
println!(
"DEBUG: No indexing data found for path: {}",
path_variant
);
}
}

println!(
"DEBUG: No matching indexed commit found. Proceeding with indexing."
);
}
Err(e) => {
eprintln!("Failed to parse metadata JSON check: {}", e)
Expand Down
Loading