fix: removed stroke artefacts inside letters#127
Merged
kyechan99 merged 1 commit intoJun 8, 2026
Conversation
|
@rastuhacode is attempting to deploy a commit to the kyechan99's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 92.77% 92.87% +0.09%
==========================================
Files 28 28
Lines 443 449 +6
Branches 103 110 +7
==========================================
+ Hits 411 417 +6
Misses 32 32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
lgtm 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126
When stroke is added and its color differs from text color the visual artifacts appear inside letters.
The fix is as follows:
paint-orderrule so fill would cover the stroke and hide inner artifacts if they existHere's the result with the fix with the same config as in the
Venomexample:Artifacts outside the letter are still visible, but fixing it is impossible with native svg strokes😞