Skip to content

fix: removed stroke artefacts inside letters #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyechan99 merged 1 commit into from
Jun 8, 2026
Merged

fix: removed stroke artefacts inside letters #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions utils/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,21 @@ export const getTextBg = (
`;
};

const getTextStrokeAttrs = (
fontColor: string,
stroke: string,
strokeWidth: number,
) => {
const hasStroke = strokeWidth > 0 && stroke !== "none";
const paintOrder = hasStroke ? "paint-order:stroke fill;" : "";

return {
style: `fill:#${fontColor};${paintOrder}`,
stroke: `#${stroke}`,
strokeWidth,
};
};

export const getText = (
text?: string,
fontColor: string = "000000",
Expand All @@ -137,6 +152,11 @@ export const getText = (
strokeWidth: number = 0,
) => {
if (!text) return "";
const { style, stroke: strokeColor, strokeWidth: width } = getTextStrokeAttrs(
fontColor,
stroke,
strokeWidth,
);
const lines = text.split("-nl-");
const alignX = Array.from(
{ length: lines.length },
Expand All @@ -154,9 +174,9 @@ export const getText = (
x="${50}%"
y="${alignY[0]}%"
class="text"
style="fill:#${fontColor};"
stroke="#${stroke}"
stroke-width="${strokeWidth}"
style="${style}"
stroke="${strokeColor}"
stroke-width="${width}"
>
${lines
.map(
Expand All @@ -174,7 +194,7 @@ export const getText = (
`;

// debate : adjustable text-anchor|pos-y. not only pos-x
return `<text text-anchor="middle" alignment-baseline="middle" x="${alignX[0]}%" y="${alignY[0]}%" class="text" style="fill:#${fontColor};" stroke="#${stroke}" stroke-width="${strokeWidth}" >${lines[0]}</text>`;
return `<text text-anchor="middle" alignment-baseline="middle" x="${alignX[0]}%" y="${alignY[0]}%" class="text" style="${style}" stroke="${strokeColor}" stroke-width="${width}" >${lines[0]}</text>`;
};

export const getDesc = (
Expand Down
Loading