Skip to content

Macos 13 brownout - #10540

Closed
jordanrfrazier wants to merge 11 commits into
mainfrom
macos-13-brownout
Closed

Macos 13 brownout#10540
jordanrfrazier wants to merge 11 commits into
mainfrom
macos-13-brownout

Conversation

@jordanrfrazier

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch macos-13-brownout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

python-version: "3.12"
# macOS-13 Brown out
# https://github.com/actions/runner-images/issues/13046
# https://github.com/godot-rust/gdext/pull/1402

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we want to update to macos-15-intel

#objc[23504]: +[MPSGraphObject initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
env:
PYTORCH_NO_MPS: 1
OBJC_DISABLE_INITIALIZE_FORK_SAFETY: YES

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do set this at startup for macos too (not implying we don't also need ti here, just mentioning) - https://github.com/langflow-ai/langflow/blob/s3-file-store/src/backend/base/langflow/__main__.py#L159

release-nightly-build:
if: github.repository == 'langflow-ai/langflow' && (needs.frontend-tests.result == 'success' || needs.frontend-tests.result == 'skipped') && (needs.backend-unit-tests.result == 'success' || needs.backend-unit-tests.result == 'skipped')
needs: create-nightly-tag
if: github.repository == 'langflow-ai/langflow'

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove the test result conditionals here we should probably make the push_to_registry flag conditional based on success of the tests

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for testing purposes. They need to be added back in once we get everything working.

@Adam-Aghili

Copy link
Copy Markdown
Collaborator

Closing as nightlys work now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants