Macos 13 brownout - #10540
Conversation
actions/runner-images#13046 godot-rust/gdext#1402 Github Actions started brownouts to make sure everyone knew about these breaking changes
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| python-version: "3.12" | ||
| # macOS-13 Brown out | ||
| # https://github.com/actions/runner-images/issues/13046 | ||
| # https://github.com/godot-rust/gdext/pull/1402 |
There was a problem hiding this comment.
Looks like we want to update to macos-15-intel
| #objc[23504]: +[MPSGraphObject initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug. | ||
| env: | ||
| PYTORCH_NO_MPS: 1 | ||
| OBJC_DISABLE_INITIALIZE_FORK_SAFETY: YES |
There was a problem hiding this comment.
We do set this at startup for macos too (not implying we don't also need ti here, just mentioning) - https://github.com/langflow-ai/langflow/blob/s3-file-store/src/backend/base/langflow/__main__.py#L159
| release-nightly-build: | ||
| if: github.repository == 'langflow-ai/langflow' && (needs.frontend-tests.result == 'success' || needs.frontend-tests.result == 'skipped') && (needs.backend-unit-tests.result == 'success' || needs.backend-unit-tests.result == 'skipped') | ||
| needs: create-nightly-tag | ||
| if: github.repository == 'langflow-ai/langflow' |
There was a problem hiding this comment.
If we remove the test result conditionals here we should probably make the push_to_registry flag conditional based on success of the tests
There was a problem hiding this comment.
This is only for testing purposes. They need to be added back in once we get everything working.
|
Closing as nightlys work now |
No description provided.