-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Macos 13 brownout #10540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macos 13 brownout #10540
Changes from all commits
6a53ce0
4f993bd
f074717
1e04121
77d24f7
41cae84
ef243c0
7ff0256
4698257
429f111
5b291b4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -89,15 +89,9 @@ jobs: | |
| arch: amd64 | ||
| runner: ubuntu-latest | ||
| python-version: "3.12" | ||
| # macOS AMD64 | ||
| - os: macos | ||
| arch: amd64 | ||
| runner: macos-13 | ||
| python-version: "3.10" | ||
| - os: macos | ||
| arch: amd64 | ||
| runner: macos-13 | ||
| python-version: "3.12" | ||
| # macOS-13 Brown out | ||
| # https://github.com/actions/runner-images/issues/13046 | ||
| # https://github.com/godot-rust/gdext/pull/1402 | ||
| # macOS ARM64 (Apple Silicon) | ||
| - os: macos | ||
| arch: arm64 | ||
|
|
@@ -332,8 +326,15 @@ jobs: | |
| - name: Test server startup (Unix) | ||
| if: matrix.os != 'windows' | ||
| timeout-minutes: 5 | ||
| #objc[23504]: +[MPSGraphObject initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug. | ||
| env: | ||
| PYTORCH_NO_MPS: 1 | ||
| OBJC_DISABLE_INITIALIZE_FORK_SAFETY: YES | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We do set this at startup for macos too (not implying we don't also need ti here, just mentioning) - https://github.com/langflow-ai/langflow/blob/s3-file-store/src/backend/base/langflow/__main__.py#L159 |
||
| OMP_NUM_THREADS: 1 | ||
| run: | | ||
| # Start server in background | ||
| echo "PYTORCH_NO_MPS=$PYTORCH_NO_MPS" | ||
| echo "PYTORCH_NFORK_SAFETYO_MPS=$OBJC_DISABLE_INITIALIZE_FORK_SAFETY" | ||
| ./test-env/bin/python -m langflow run --host localhost --port 7860 --backend-only & | ||
| SERVER_PID=$! | ||
|
|
||
|
|
@@ -392,10 +393,6 @@ jobs: | |
| arch: amd64 | ||
| runner: ubuntu-latest | ||
| python-version: "3.13" | ||
| - os: macos | ||
| arch: amd64 | ||
| runner: macos-13 | ||
| python-version: "3.13" | ||
| - os: macos | ||
| arch: arm64 | ||
| runner: macos-latest | ||
|
|
@@ -620,6 +617,10 @@ jobs: | |
| - name: Test server startup (Unix) | ||
| if: matrix.os != 'windows' | ||
| timeout-minutes: 5 | ||
| env: | ||
| PYTORCH_NO_MPS: 1 | ||
| OBJC_DISABLE_INITIALIZE_FORK_SAFETY: YES | ||
| OMP_NUM_THREADS: 1 | ||
| run: | | ||
| # Start server in background | ||
| ./test-env/bin/python -m langflow run --host localhost --port 7860 --backend-only & | ||
|
|
@@ -712,4 +713,4 @@ jobs: | |
| else | ||
| echo "❌ Critical platform tests were skipped unexpectedly" | ||
| exit 1 | ||
| fi | ||
| fi | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,11 @@ on: | |
| required: false | ||
| type: boolean | ||
| default: false | ||
| skip_slack: | ||
| description: "Skip slack message on failure. Only do this for testing purposes." | ||
| required: false | ||
| type: boolean | ||
| default: false | ||
| push_to_registry: | ||
| description: "Whether to push images to registries. Set to false for testing builds without publishing." | ||
| required: false | ||
|
|
@@ -210,9 +215,9 @@ jobs: | |
| # ref: ${{ needs.create-nightly-tag.outputs.tag }} | ||
|
|
||
| release-nightly-build: | ||
| if: github.repository == 'langflow-ai/langflow' && (needs.frontend-tests.result == 'success' || needs.frontend-tests.result == 'skipped') && (needs.backend-unit-tests.result == 'success' || needs.backend-unit-tests.result == 'skipped') | ||
| needs: create-nightly-tag | ||
| if: github.repository == 'langflow-ai/langflow' | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we remove the test result conditionals here we should probably make the
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is only for testing purposes. They need to be added back in once we get everything working. |
||
| name: Run Nightly Langflow Build | ||
| needs: [create-nightly-tag, frontend-tests, backend-unit-tests] | ||
| uses: ./.github/workflows/release_nightly.yml | ||
| with: | ||
| build_docker_base: true | ||
|
|
@@ -229,7 +234,7 @@ jobs: | |
| slack-notification: | ||
| name: Send Slack Notification | ||
| needs: [frontend-tests, backend-unit-tests, release-nightly-build] | ||
| if: ${{ github.repository == 'langflow-ai/langflow' && always() && (needs.release-nightly-build.result == 'failure' || needs.frontend-tests.result == 'failure' || needs.backend-unit-tests.result == 'failure' || needs.release-nightly-build.result == 'success') }} | ||
| if: ${{ github.repository == 'langflow-ai/langflow' && !inputs.skip_slack && always() && (needs.release-nightly-build.result == 'failure' || needs.frontend-tests.result == 'failure' || needs.backend-unit-tests.result == 'failure' || needs.release-nightly-build.result == 'success') }} | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Send failure notification to Slack | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we want to update to
macos-15-intel