fix: enable agent-lifecycle-toolkit (altk) on Python 3.14 - #13513
Merged
Conversation
agent-lifecycle-toolkit 0.10.x dropped its own requires-python <3.14 cap (now >=3.10) and does not depend on OpenDsStar, so the `python_version < '3.14'` gate on the altk extra is stale. - Remove the python_version < '3.14' marker from the altk extra in langflow-base, keeping the macOS x86_64 platform exclusion. - Regenerate uv.lock: agent-lifecycle-toolkit resolves on 3.14 and coexists with the onnxruntime>=1.26 langflow forces there (verified agent-lifecycle-toolkit 0.10.1 + onnxruntime 1.26.0). OpenDsStar (the separate OpenDsStarAgent component) stays gated: all its releases still cap requires-python at <3.14 upstream.
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe PR updates the ChangesDependency Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 2 warnings)
✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
✅ Test Coverage AdvisorNo source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉
|
github-actions
Bot
added
bug
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/backend/base/pyproject.toml`:
- Around line 340-343: The test contains an outdated comment claiming
"agent-lifecycle-toolkit is gated to python_version<'3.14' upstream"; update
that comment in
src/backend/tests/unit/components/models_and_agents/test_altk_agent.py (around
the top of the file) to reflect that the upstream package no longer enforces a
<3.14 python_version gate (e.g., note that agent-lifecycle-toolkit>=0.10.1
removed the <3.14 cap and now requires >=3.10), keeping the rest of the test
intact and preserving any context around the comment.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7c63684a-373e-4d16-b01f-ba550df0379e
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
src/backend/base/pyproject.toml
Comment on lines
+340
to
+343
| # Python 3.14: agent-lifecycle-toolkit 0.10.x dropped its own <3.14 cap (now | ||
| # requires-python >=3.10) and does not depend on OpenDsStar, so the python_version | ||
| # gate is removed; the dependency tree resolves on 3.14 within the langflow lock. | ||
| altk = ["agent-lifecycle-toolkit>=0.10.1,<1.0; sys_platform != 'darwin' or platform_machine != 'x86_64'"] |
Contributor
There was a problem hiding this comment.
Update the outdated comment in the test file.
The test file src/backend/tests/unit/components/models_and_agents/test_altk_agent.py at lines 9-10 contains an outdated comment stating that "agent-lifecycle-toolkit is gated to python_version<'3.14' upstream". Since this PR removes that gate, the comment should be updated to reflect the current state.
📝 Suggested comment update
In src/backend/tests/unit/components/models_and_agents/test_altk_agent.py:
try:
import altk # noqa: F401
except ImportError:
- # agent-lifecycle-toolkit is gated to python_version<'3.14' upstream.
- pytest.skip("altk (agent-lifecycle-toolkit) not available", allow_module_level=True)
+ # altk is an optional extra; skip tests when not installed.
+ pytest.skip("altk (agent-lifecycle-toolkit) not available", allow_module_level=True)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/backend/base/pyproject.toml` around lines 340 - 343, The test contains an
outdated comment claiming "agent-lifecycle-toolkit is gated to
python_version<'3.14' upstream"; update that comment in
src/backend/tests/unit/components/models_and_agents/test_altk_agent.py (around
the top of the file) to reflect that the upstream package no longer enforces a
<3.14 python_version gate (e.g., note that agent-lifecycle-toolkit>=0.10.1
removed the <3.14 cap and now requires >=3.10), keeping the rest of the test
intact and preserving any context around the comment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.10.0 #13513 +/- ##
==================================================
+ Coverage 57.99% 58.19% +0.19%
==================================================
Files 2280 2281 +1
Lines 218123 218942 +819
Branches 30984 32268 +1284
==================================================
+ Hits 126502 127407 +905
+ Misses 90183 90097 -86
Partials 1438 1438
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Frontend Unit Test Coverage ReportCoverage Summary
Unit Test Results
|
The module-level import skips in the ALTK agent tests carried an outdated comment claiming "agent-lifecycle-toolkit is gated to python_version<'3.14' upstream". That is no longer accurate: agent-lifecycle-toolkit 0.10.1 dropped the <3.14 cap (now requires >=3.10), and this PR removes the langflow <3.14 marker on the altk extra. The skip itself is preserved -- altk is an optional extra (langflow-base[altk]) that may be absent from a given environment, so the ImportError guard is still required. Only the comment is corrected, to state the real reason for the skip plus the upstream change. Applied to all four files carrying the identical comment (test_altk_agent, test_altk_agent_logic, test_altk_agent_tool_conversion, test_conversation_context_ordering). Also tag a pre-existing fake test key (api_key="sk-test") with `# pragma: allowlist secret`; the comment shift re-staged the file and surfaced it to detect-secrets. Validated (Python 3.13, altk installed): ruff clean; the three logic modules run (64 passed, 4 skipped) and test_altk_agent collects (13).
github-actions
Bot
added
bug
This was referenced Jun 23, 2026
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
altkextra (agent-lifecycle-toolkit) inlangflow-basewas gated withpython_version < '3.14', so on the Python 3.14 Docker image /pip installit silently resolved to nothing and the Agent Lifecycle Toolkit features were unavailable.That gate is now stale:
agent-lifecycle-toolkit0.10.1 declaresrequires-python = '>=3.10'— it no longer caps at<3.14.OpenDsStar(checked all 47requires_distentries + every extra). The two were independent gates; only OpenDsStar is genuinely still blocked (see below).Change
python_version < '3.14'marker from thealtkextra insrc/backend/base/pyproject.toml, keeping the macOS x86_64 platform exclusion (PyTorch dropped Intel-Mac wheels after v2.2.2).uv.lock.Verification
uv lockresolves cleanly (804 packages, no conflict). The lock'sagent-lifecycle-toolkitedge is now gated only byextra == 'altk'+ the platform exclusion — thepython_version < '3.14'cap is gone.onnxruntime>=1.26on 3.14 (langflow holds onnxruntime to<1.24on<3.14"for altk compatibility"). Confirmed they coexist on 3.14:Scope
altkextra; it does not change the default image's dependency set.1.0.26) still declaresrequires-python = '>=3.11,<3.14'upstream, so theOpenDsStarAgentcomponent remains correctly excluded on 3.14 until that upstream cap is lifted. Tracked separately from this PR.Test plan
uv lockresolves without conflictuv.lockno longer carries a< '3.14'markeragent-lifecycle-toolkit0.10.1 +onnxruntime1.26.0 co-resolve on Python 3.14Summary by CodeRabbit