Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/backend/base/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,10 @@ spider = ["spider-client>=0.0.27,<1.0.0"]
# Updated to 0.10.1+ for PyTorch 2.6.0 compatibility (addresses torch.load RCE vulnerability)
# Upper bound prevents breaking changes in future major versions
# Excluded on macOS x86_64: PyTorch dropped Intel Mac wheel builds after v2.2.2
altk = ["agent-lifecycle-toolkit>=0.10.1,<1.0; (sys_platform != 'darwin' or platform_machine != 'x86_64') and python_version < '3.14'"]
# Python 3.14: agent-lifecycle-toolkit 0.10.x dropped its own <3.14 cap (now
# requires-python >=3.10) and does not depend on OpenDsStar, so the python_version
# gate is removed; the dependency tree resolves on 3.14 within the langflow lock.
altk = ["agent-lifecycle-toolkit>=0.10.1,<1.0; sys_platform != 'darwin' or platform_machine != 'x86_64'"]
Comment on lines +340 to +343

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Update the outdated comment in the test file.

The test file src/backend/tests/unit/components/models_and_agents/test_altk_agent.py at lines 9-10 contains an outdated comment stating that "agent-lifecycle-toolkit is gated to python_version<'3.14' upstream". Since this PR removes that gate, the comment should be updated to reflect the current state.

📝 Suggested comment update

In src/backend/tests/unit/components/models_and_agents/test_altk_agent.py:

 try:
     import altk  # noqa: F401
 except ImportError:
-    # agent-lifecycle-toolkit is gated to python_version<'3.14' upstream.
-    pytest.skip("altk (agent-lifecycle-toolkit) not available", allow_module_level=True)
+    # altk is an optional extra; skip tests when not installed.
+    pytest.skip("altk (agent-lifecycle-toolkit) not available", allow_module_level=True)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/backend/base/pyproject.toml` around lines 340 - 343, The test contains an
outdated comment claiming "agent-lifecycle-toolkit is gated to
python_version<'3.14' upstream"; update that comment in
src/backend/tests/unit/components/models_and_agents/test_altk_agent.py (around
the top of the file) to reflect that the upstream package no longer enforces a
<3.14 python_version gate (e.g., note that agent-lifecycle-toolkit>=0.10.1
removed the <3.14 cap and now requires >=3.10), keeping the rest of the test
intact and preserving any context around the comment.


# Toolguard Integration
toolguard = ["toolguard>=0.2.16,<1.0.0"]
Expand Down
Loading
Loading