LEGLINK-653: Reduce routine validation-result persistence to submittable categories

[johnbritton]

🛠️ Description of Changes

Only persist validation results that are categorized with submit: true.

🧪 Testing Performed

Ran Ad Hoc report and observed that only results with submit: true were added in the database.

🧑‍🔬 Unit Testing

• I have written or updated unit tests to cover my changes
• Coverage: 100.0%

📓 Documentation Updated

Please update any relevant sections in the project documentation that were impacted by the changes in the PR.

Summary by CodeRabbit

• Bug Fixes

  • Validation results are now saved only when they include at least one category eligible for submission.
  • Results without categories or without submit-enabled categories are excluded from persistence.
  • Multi-category results are handled correctly, including cases where only some categories are submit-enabled.

• Tests

  • Added coverage confirming category submission settings are correctly retained and updated during re-imports.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1e5f1492-efc5-497b-8fc7-bb271c336647

📥 Commits

Reviewing files that changed from the base of the PR and between b7647b4 and 6084aca.

📒 Files selected for processing (3)

• Java/validation/src/main/java/com/lantanagroup/link/validation/services/ReadyForValidationConsumer.java
• Java/validation/src/test/java/com/lantanagroup/link/validation/services/CategoryInitializationJpaTest.java
• Java/validation/src/test/java/com/lantanagroup/link/validation/services/ReadyForValidationConsumerTest.java

---

📝 Walkthrough

Walkthrough

ReadyForValidationConsumer now persists only validation results with at least one submit-enabled category. Tests cover category re-import state, mixed-category results, and empty eligible-result sets.

Changes

Validation result persistence

Layer / File(s)	Summary
Category submit state Java/validation/src/test/java/com/lantanagroup/link/validation/services/CategoryInitializationJpaTest.java	The re-import test verifies submit=false after the initial import and submit=true after the revised import.
Eligible result filtering Java/validation/src/main/java/com/lantanagroup/link/validation/services/ReadyForValidationConsumer.java, Java/validation/src/test/java/com/lantanagroup/link/validation/services/ReadyForValidationConsumerTest.java	The consumer filters results by Category::isSubmit and skips saveAll when no result is eligible. Tests cover single-category, multi-category, and uncategorized results.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 6084a

The change narrowly limits persisted validation results to categories marked submit=true, with no actionable merge-blocking risk remaining beyond normal checks and review.

Possibly related PRs

• lantanagroup/link-cloud#1766: Both verify persisted category fields during category re-import.
• lantanagroup/link-cloud#1801: Both modify validation-result persistence filtering in ReadyForValidationConsumer.
• lantanagroup/link-cloud#1816: Both use the validation category submit flag for persistence behavior.

Suggested reviewers: mikeatpinnacle, seanmcilvenna, smailliwcs

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes reducing validation-result persistence to submittable categories.
Description check	✅ Passed	The description covers the changes, testing, unit-test coverage, and documentation section required by the template.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch users/jbritton/LEGLINK-653

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}