Skip to content

refactor: rename "API Keys" settings page to "Models" - #1313

Merged
lfnovo merged 4 commits into
lfnovo:mainfrom
AugustoSandim:refactor/standardize-models-area
Sep 5, 2026
Merged

refactor: rename "API Keys" settings page to "Models"#1313
lfnovo merged 4 commits into
lfnovo:mainfrom
AugustoSandim:refactor/standardize-models-area

Conversation

@AugustoSandim

@AugustoSandim AugustoSandim commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Renames the provider credentials settings area from "API Keys" to "Models", per #1199.

Changes

  • Route: /settings/api-keys/settings/models, with a permanent redirect (308) so existing bookmarks and links keep working.
  • UI copy: page title, description, and "learn more" link now use "Models" wording.
  • i18n: updated display values across all 14 locales (i18n key names unchanged).
  • Internal links: sidebar, setup banner, and command palette now point to /settings/models.
  • Docs: navigation references updated to Manage → Models (the Models page lives under the sidebar's "Manage" section); quick-start-local.md fixed so its LM Studio block, step 9, and "Going Further" use "Manage → Models" consistently (CHANGELOG left untouched).
  • Sidebar: fixed the active-item highlight so the Models page no longer also highlights Settings — /settings/models is a URL child of /settings, so the old startsWith matched both; now uses a longest-prefix match.

Testing

  • npm run lint — 0 errors
  • npm run test — 145 passed (includes locale parity test)
  • npm run build — passes; route table shows /settings/models
  • AppSidebar.test.tsx — added a regression test: on the Models page only Models is highlighted, not Settings

Closes #1199

Review in cubic

Rename the provider credentials settings area from "API Keys" to "Models":

- Route: /settings/api-keys -> /settings/models with a permanent redirect
- UI copy: page title, description, and learn-more now use "Models" wording
- i18n: updated display values across all 14 locales (key names unchanged)
- Internal links: sidebar, setup banner, and command palette point to /settings/models
- Docs: "Settings → API Keys" references updated to "Settings → Models"
@AugustoSandim
AugustoSandim force-pushed the refactor/standardize-models-area branch from d97085c to 1242d91 Compare September 4, 2026 22:39
@AugustoSandim
AugustoSandim marked this pull request as ready for review September 4, 2026 22:40

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 42 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread docs/0-START-HERE/quick-start-local.md Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread docs/0-START-HERE/quick-start-local.md
@AugustoSandim
AugustoSandim force-pushed the refactor/standardize-models-area branch from 7cf90f0 to 1242d91 Compare September 4, 2026 23:47
AugustoSandim and others added 3 commits September 4, 2026 19:56
Use longest-prefix matching so parent items like Settings don't also
highlight when viewing a child page such as Models. Add test coverage
for the Models page active state.
…models-area

# Conflicts:
#	docs/5-CONFIGURATION/environment-reference.md
#	docs/5-CONFIGURATION/ollama.md
@lfnovo
lfnovo merged commit bbc7d11 into lfnovo:main Sep 5, 2026
13 checks passed
lfnovo added a commit that referenced this pull request Sep 5, 2026
* docs: standardize Models navigation path to "Manage → Models"

The Models page (/settings/models) is rendered under the sidebar's
"Manage" section as a sibling of Settings, not as a child of it
(frontend/src/components/layout/AppSidebar.tsx). The docs mixed
"Settings → Models" (~150 occurrences) with the correct "Manage → Models"
(3). Standardize every doc, the backend error-message hints and the
speaches compose example on "Manage → Models". CHANGELOG is historical
and left untouched. No routes or behaviour changed.

Follow-up to the P2 note on #1313.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012heLWVTmopC5FkipUgnvsN

* docs: fix remaining multi-step "Settings → Models" instructions

Addresses cubic P2s on #1330: two sections spelled the old path out as
separate steps ("Click Settings… Select Models tab"), plus a few
shorthand "in Settings" mentions that refer to the Models page.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012heLWVTmopC5FkipUgnvsN

* docs: fix step numbering in quick-start-cloud after merging nav steps

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012heLWVTmopC5FkipUgnvsN

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: standardize the credentials area on "Models" (route, page labels, docs)

2 participants