Fix snapshot builds - #963
Merged
Merged
Conversation
|
|
pblazej
changed the title
Recent main-snapshot toolchains crash at build startup with "unable to find bundle named SwiftBuild_SWBUniversalPlatform" (SwiftPM's SwiftBuild integration cannot locate its resource bundles on the CI image). This prevents the job from ever reaching Swift compilation. Pass --build-system native to fall back to the classic SwiftPM build system, which is sufficient for the workflow's goal of validating the package against upcoming Swift. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pblazej
force-pushed
the
blaze/fix-snapshot-build
branch
from
April 13, 2026 09:18
16fbd68 to
da13344
Compare
v4 runs on Node.js 20 which GitHub Actions is deprecating (forced to Node.js 24 by default on 2026-06-02, removed on 2026-09-16). v5 runs on Node.js 24. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
v3/v4 run on Node.js 20, which GitHub Actions is deprecating (forced to Node 24 on 2026-06-02, removed on 2026-09-16). v5 ships on Node 24. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…init Swift 6.3 (main-snapshot) tightened @mainactor init isolation: once self is copied into a nonisolated context (e.g. an actor init), subsequent self.<property> accesses in the same init are rejected with: error: cannot access 'self' here in main actor-isolated initializer note: after making a copy of 'self', only main actor-isolated properties of 'self' can be accessed from this init Introduce a local `room` binding so downstream TextMessageSender / TranscriptionStreamReceiver / observe(room:) calls don't implicitly read self.room. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
v6 is the current stable release (v6.0.2) and runs on Node.js 24. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pblazej
commented
Apr 13, 2026
| senders: [any MessageSender]?, | ||
| receivers: [any MessageReceiver]?) | ||
| { | ||
| let room = options.room |
Contributor
Author
There was a problem hiding this comment.
This is required due to hardened self access in MainActor isolated init.
Contributor
Author
|
Build: https://github.com/livekit/client-sdk-swift/actions/runs/24336559363/job/71054753156 Warnings in separate PRs. |
pblazej
marked this pull request as ready for review
April 13, 2026 09:50
hiroshihorie
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Haven't found a better workaround yet - it's more about testing newer Swift than SPM itself.