Skip to content

Fix snapshot builds #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pblazej merged 5 commits into from
Apr 13, 2026
Merged

Fix snapshot builds #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da13344
ci: use native build system for swift snapshot workflow
pblazej Apr 13, 2026
a16a6bc
ci(snapshot): upgrade actions/checkout to v5
pblazej Apr 13, 2026
ea614bd
ci: upgrade actions/checkout to v5 across all workflows
pblazej Apr 13, 2026
32a23ed
fix(agent): avoid self access after actor init in @MainActor Session …
pblazej Apr 13, 2026
0a2e826
ci: bump actions/checkout to v6 across all workflows
pblazej Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
run:
shell: bash
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Install LiveKit Server
run: brew install livekit
Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:
name: Lint
runs-on: macos-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Install SwiftLint
run: brew install swiftlint
- name: SwiftLint
Expand All @@ -195,7 +195,7 @@ jobs:
runs-on: macos-15
steps:
- name: Checkout Documentation Catalog
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
sparse-checkout: Sources/LiveKit/LiveKit.docc

Expand Down Expand Up @@ -230,7 +230,7 @@ jobs:
name: Check Protocol
runs-on: macos-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
submodules: recursive

Expand Down Expand Up @@ -260,7 +260,7 @@ jobs:
contents: read
pull-requests: write
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cocoapods-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
timeout-minutes: 30
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v6
- name: Setup CocoaPods
uses: maxim-lobanov/setup-cocoapods@v1
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
artifact_name: symbol-graph-macos
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
ref: ${{ github.event_name == 'release' && github.event.release.tag_name || github.event.inputs.ref || 'main' }}
fetch-depth: 0
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
runs-on: macos-26
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
ref: ${{ github.event_name == 'release' && github.event.release.tag_name || github.event.inputs.ref || 'main' }}
fetch-depth: 0
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/swift-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run:
shell: bash
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- uses: maxim-lobanov/setup-xcode@v1
with:
Expand All @@ -33,4 +33,7 @@ jobs:
run: swiftly install -y ${{ env.SWIFT_SNAPSHOT }}

- name: Build
run: swiftly run swift build +${{ env.SWIFT_SNAPSHOT }}
# --build-system native avoids a SwiftBuild resource-bundle crash
# ("unable to find bundle named SwiftBuild_SWBUniversalPlatform")
# seen in recent main-snapshot toolchains on the CI image.
run: swiftly run swift build +${{ env.SWIFT_SNAPSHOT }} --build-system native
3 changes: 2 additions & 1 deletion Sources/LiveKit/Agent/Session.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,10 @@ open class Session: ObservableObject {
senders: [any MessageSender]?,
receivers: [any MessageReceiver]?)
{
let room = options.room

@pblazej pblazej Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required due to hardened self access in MainActor isolated init.

self.tokenSourceConfiguration = tokenSourceConfiguration
self.options = options
room = options.room
self.room = room

let textMessageSender = TextMessageSender(room: room)
let resolvedSenders = senders ?? [textMessageSender]
Expand Down
Loading