fix(ci): clear knip unused-exports failures on dev#119
Merged
Conversation
The `npm run knip` step in the TypeScript/Lint/Tests workflow has been red on every push to dev since 55091f0. Two distinct sources: - `MessageLoadResult` in `useChatStore.ts` was exported but only consumed in the same file (as the type of an internal store field). Demote to a file-private interface. - `KnownBridgeKey` and `DataBridgeProbeResult` in `theia/dataBridgeReader.ts` were exported (and re-exported through `theia/index.ts`) for use as type annotations at call sites that actually rely on TypeScript inference. The exports were never read. Demote to file-private and drop the barrel re-exports. Also drop the redundant `esbuild.js` entry from `knip.json` — knip auto-detects build configs and was flagging it as a configuration hint. After this commit, `npm run knip` exits 0 locally with no warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI `TypeScript, Lint & Tests / Dead code analysis` step (`npm run knip`) has been red on every push to `dev` since 55091f0. This PR clears the three offending exports plus one redundant config entry.
Changes
Test plan
Notes