update check for Unicode support#144
Open
norweeg wants to merge 9 commits into
Open
Conversation
0d582d7 to
6ae75b8
Compare
c95d85d to
cf5c893
Compare
Closed
3 tasks
…a jupyter notebook
…determine unicode support
70c20de to
34a9ce6
Compare
Author
|
@manrajgrover can you take a look at this?? AppVeyor is failing not on my code change, but at the environment setup for Python 3.7. It can't install pywinpyt which must be a dependency of something required for testing because a Go compiler is not installed on the test server. I believe once that problem is resolved, all tests will pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of new feature, or changes
removes unnecessary system check for Unicode outputchanges Unicode support check to instead use the encoder supported by
sys.stdoutto try to encode a Unicode character. If it succeeds, Unicode is supported, otherwise it is notresolves #5
resolves #25
resolves #141
obsoletes #142
see #5 (comment)
Checklist
Related Issues and Discussions
People to notify