Skip to content

update check for Unicode support#144

Open
norweeg wants to merge 9 commits into
manrajgrover:masterfrom
norweeg:remove-terminal-check
Open

update check for Unicode support#144
norweeg wants to merge 9 commits into
manrajgrover:masterfrom
norweeg:remove-terminal-check

Conversation

@norweeg

@norweeg norweeg commented Mar 7, 2020

Copy link
Copy Markdown

Description of new feature, or changes

removes unnecessary system check for Unicode output
changes Unicode support check to instead use the encoder supported by sys.stdout to try to encode a Unicode character. If it succeeds, Unicode is supported, otherwise it is not

resolves #5
resolves #25
resolves #141
obsoletes #142

see #5 (comment)

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature
  • All tests are passing

Related Issues and Discussions

People to notify

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 432

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 429: 0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@norweeg norweeg force-pushed the remove-terminal-check branch from 70c20de to 34a9ce6 Compare April 2, 2023 18:04
@norweeg norweeg changed the title remove unnecessary system check for Unicode output update check for Unicode support Apr 2, 2023
@norweeg

norweeg commented Apr 2, 2023

Copy link
Copy Markdown
Author

@manrajgrover can you take a look at this?? AppVeyor is failing not on my code change, but at the environment setup for Python 3.7. It can't install pywinpyt which must be a dependency of something required for testing because a Go compiler is not installed on the test server. I believe once that problem is resolved, all tests will pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spinner overwritten in Jupyter on Windows emojis not show Improve Windows Support

2 participants