done - #4530
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation is functional and meets most requirements, but there's a checklist violation that needs to be addressed. At lines 34-37, you're using the indexOf + splice pattern to remove dead animals, but [CHECKLIST ITEM #1] explicitly requires using filter instead. Replace that block with Animal.alive = Animal.alive.filter(a => a.health > 0);. This ensures cleaner, more functional code that avoids mutation of the original array.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| if (animal.health <= 0) { | ||
| const index = Animal.alive.indexOf(animal); | ||
|
|
||
| Animal.alive.splice(index, 1); |
There was a problem hiding this comment.
Checklist item #1 violation: Use filter instead of indexOf + splice for removing dead animals. Replace the indexOf/splice block with Animal.alive = Animal.alive.filter(a => a.health > 0);
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. All requirements are met, including the fix to checklist item #1 - the indexOf + splice pattern has been correctly replaced with the filter method on lines 34-35. The code properly implements inheritance with static arrays for Herbivore and Carnivore, and the bite/hide mechanics work as expected. Great job addressing the previous feedback!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.