Skip to content
Open

done #4530

Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions src/herbivoresAndCarnivores.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,42 @@
'use strict';

class Animal {
// write your code here
static alive = [];

constructor(name) {
this.name = name;
this.health = 100;

Animal.alive.push(this);
}
}

class Herbivore extends Animal {
// write your code here
constructor(name) {
super(name);

this.hidden = false;
}

hide() {
this.hidden = true;
}
}

class Carnivore extends Animal {
// write your code here
bite(animal) {
if (animal instanceof Carnivore || animal.hidden) {
return;
}

animal.health -= 50;

if (animal.health <= 0) {
const index = Animal.alive.indexOf(animal);

Animal.alive.splice(index, 1);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item #1 violation: Use filter instead of indexOf + splice for removing dead animals. Replace the indexOf/splice block with Animal.alive = Animal.alive.filter(a => a.health > 0);

}
}
}

module.exports = {
Expand Down
Loading