Skip to content

N-04: revert on invalid BUNDLE_IDENTIFIER in GWAssetTracker#2123

Open
valera-grinenko-ai wants to merge 1 commit intomatter-labs:draft-v31from
valera-grinenko-ai:pr/N-04-bundle-identifier-revert
Open

N-04: revert on invalid BUNDLE_IDENTIFIER in GWAssetTracker#2123
valera-grinenko-ai wants to merge 1 commit intomatter-labs:draft-v31from
valera-grinenko-ai:pr/N-04-bundle-identifier-revert

Conversation

@valera-grinenko-ai
Copy link
Copy Markdown

Summary

  • Replaces return 0 with revert InvalidBundleIdentifier() in GWAssetTracker._handleInteropCenterMessage when BUNDLE_IDENTIFIER check fails
  • The existing comment stated this should not be possible in V31 and should trigger a revert, but the code silently returned 0 instead

Test plan

  • Verify forge build passes
  • Confirm invalid messages (wrong first byte) cause a revert instead of silent return
  • Confirm valid bundle messages still process correctly

🤖 Generated with Claude Code

The comment stated this should not be possible in V31 and should
trigger a revert, but the code returned 0 instead. Replace the
silent return with an explicit revert to align with the V31 spec.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants